This repository was archived by the owner on Dec 5, 2024. It is now read-only.
Fix: repository reset now tracks actual git refs #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pth tests for repository reset
Larusso
approved these changes
Jun 29, 2021
|
oh what a stupid mistake. As of PRs as refs that is quite smart since refs are just references and git itself is just a virtual filesystem. I thought about adding custom refs for our tooling as well. Mainly encoding versions etc. Gerrit uses refs to encode PR comments. Since one can create arbitary blob objects/shas in the git storage and connect them via custom refs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repository reset operation was comparing the captured refs with themselves. Fix now makes it compare the captured refs with current repository refs.
Also had to add a conditional explicitly excluding PRs from the ref iteration, as for some reason github puts PRs as refs 🤔
Also added more in depth testing for the repository reset operation, and updated github-api lib to latest version.
Changes
org.kohsuke:github-apilibrary to 1.131