This repository has been archived by the owner on Dec 5, 2024. It is now read-only.
Fix sigh renew password set through environment #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Azurelol
reviewed
Jul 19, 2022
src/integrationTest/groovy/wooga/gradle/fastlane/tasks/SighRenewIntegrationSpec.groovy
Outdated
Show resolved
Hide resolved
Larusso
force-pushed
the
fix/password_set_through_environment
branch
from
0b57aa5 to
4efab22
Compare
Description =========== This is a small patch which only involves to bump `com.wooga.gradle:gradle-commons` to min version `1.5.1`. We need the functionality of the `ExecSpec`/`ProcessExecutor` to handle environment values correctly. The latest version had a bug and was not pushing the values provided in the environment map to the executable. I adjusted the tests to actually test the values being passed to the called process instead of checking the task properties only. Changes ======= * ![FIX] sigh renew password set through environment
Larusso
force-pushed
the
fix/password_set_through_environment
branch
from
4efab22 to
817a72e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a small patch which only involves to bump
com.wooga.gradle:gradle-commonsto min version1.5.1. We need the functionality of theExecSpec/ProcessExecutorto handle environment values correctly. The latest version had a bug and was not pushing the values provided in the environment map to the executable.I adjusted the tests to actually test the values being passed to the called process instead of checking the task properties only.
Changes