Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migration to fix zero forge_id in orgs table #4924

Merged
merged 2 commits into from
Mar 4, 2025
Merged

Conversation

xoxys
Copy link
Member

@xoxys xoxys commented Mar 3, 2025

Fixes: #4918

  • drive-by fix that unifies the migration file names
  • add migration for forge_id=0 in orgs table

I have not worked much with XORM and even less with the migrations, so please let me know if this is wrong.

@xoxys xoxys added bug Something isn't working server labels Mar 3, 2025
@xoxys xoxys requested a review from a team March 3, 2025 19:43
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.26%. Comparing base (a3cc61b) to head (3287f35).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4924      +/-   ##
==========================================
+ Coverage   26.25%   26.26%   +0.01%     
==========================================
  Files         399      400       +1     
  Lines       28397    28401       +4     
==========================================
+ Hits         7456     7460       +4     
  Misses      20268    20268              
  Partials      673      673              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lafriks lafriks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good but what is the source of such records being created?

@qwerty287
Copy link
Contributor

I think the problem was that when we added the forge_id column we didn't set a default value so on all old records it was set to 0.

@xoxys
Copy link
Member Author

xoxys commented Mar 4, 2025

@xoxys xoxys merged commit 780f838 into main Mar 4, 2025
9 checks passed
@xoxys xoxys deleted the migrate-zero-forge-id branch March 4, 2025 06:56
@woodpecker-bot woodpecker-bot mentioned this pull request Mar 4, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot enable new repos after upgrading from v3.1.0 to v3.2.0. Duplicate entry for key 'UQE_orgs_name'
3 participants