Fix org assign on login

[anbraten]

Changes

• fix error when assigning org to user (the wrong error was handled)
• enhance log messages

[woodpecker-bot]

Deployment of preview was torn down

[xoxys]

Will you take care of reverting the changes in #4762 as well?

[anbraten]

Will merge main afterwards into #4762

[codecov]

Codecov Report

Attention: Patch coverage is 30.00000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 28.28%. Comparing base (b78427e) to head (6cf190d).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
server/api/login.go	22.22%	13 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4817      +/-   ##
==========================================
- Coverage   28.29%   28.28%   -0.02%     
==========================================
  Files         398      398              
  Lines       28301    28303       +2     
==========================================
- Hits         8008     8005       -3     
- Misses      19583    19588       +5     
  Partials      710      710              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[qwerty287]

I'd still rather have it done now already but if you don't want I also can't change it. Will block #4762 then though until that's resolved.

[anbraten]

Ahh, didn't got your point. If you think it fits better in here I can add the store query using Forge-id and org-name.

[anbraten]

lgtm now

[qwerty287]

@anbraten can you fix https://ci.woodpecker-ci.org/repos/3780/pipeline/25527/37#L6?

If I fix it I can't approve the PR again and you can't either

[anbraten]

Should we add the forgeId for queries to the repo lookup by name as well?

woodpecker/server/router/middleware/session/repo.go

Line 66 in e1f31da

repo, err = _store.GetRepoName(fullName)

woodpecker/server/api/badge.go

Line 51 in e1f31da

repo, err = _store.GetRepoName(c.Param("repo_id_or_owner") + "/" + c.Param("repo_name"))

[qwerty287]

Yes, I think so