Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save agent-id for tasks and add endpoint to get agent tasks #1631

Merged
merged 15 commits into from
Mar 21, 2023

Conversation

anbraten
Copy link
Member

@anbraten anbraten commented Mar 16, 2023

Save which agent is running a task. This is now visible in the admin UI in the queue and in the agent details screen.

changes

  • save id of agent executing a task
  • add endpoint to get tasks of an agent for Autoscaler #999
  • show assigned agent-id in queue
  • show tasks of an agent in agent details
  • (offtopic) use same colors for queue stats and icons (similar to the ones used by pipelines)
  • (offtopic) use badges for queue labels & dependencies

image

@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2023

Codecov Report

Patch coverage: 30.00% and project coverage change: +0.03 🎉

Comparison is base (46452fb) 39.30% compared to head (e8dfbd0) 39.33%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1631      +/-   ##
==========================================
+ Coverage   39.30%   39.33%   +0.03%     
==========================================
  Files         167      167              
  Lines       10852    10848       -4     
==========================================
+ Hits         4265     4267       +2     
+ Misses       6313     6307       -6     
  Partials      274      274              
Impacted Files Coverage Δ
server/grpc/rpc.go 0.00% <0.00%> (ø)
server/model/step.go 43.63% <ø> (ø)
server/model/task.go 0.00% <ø> (ø)
server/queue/persistent.go 0.00% <0.00%> (ø)
server/queue/queue.go 0.00% <ø> (ø)
server/queue/fifo.go 83.33% <100.00%> (+0.13%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@anbraten anbraten changed the title Set agent-id for steps Save agent-id for tasks and add endpoint to get agent tasks Mar 21, 2023
@anbraten anbraten marked this pull request as ready for review March 21, 2023 07:33
@anbraten anbraten added server ui frontend related enhancement improve existing features labels Mar 21, 2023
@anbraten anbraten added this to the 1.0.0 milestone Mar 21, 2023
@anbraten anbraten requested a review from a team March 21, 2023 07:35
@anbraten anbraten mentioned this pull request Mar 21, 2023
15 tasks
@lafriks lafriks merged commit f13ffc2 into woodpecker-ci:master Mar 21, 2023
@anbraten anbraten deleted the agent-id branch March 21, 2023 13:10
@lafriks
Copy link
Contributor

lafriks commented Mar 21, 2023

actually after looking again, maybe do not show platform if it's not specified instead of ???? It does not add any valuable information and just takes up space

@anbraten
Copy link
Member Author

@lafriks Good point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improve existing features server ui frontend related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants