Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to sort via semver before determin latest tag #146

Merged
merged 5 commits into from
Jul 21, 2024

Conversation

6543
Copy link
Member

@6543 6543 commented Jul 19, 2024

close #145

image

@6543 6543 requested a review from anbraten July 19, 2024 12:09
@6543 6543 added the enhancement Enhance existing feature label Jul 21, 2024
@6543 6543 requested a review from a team July 21, 2024 13:12
Copy link
Contributor

@qwerty287 qwerty287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested from my side

@lafriks lafriks merged commit ca50d45 into main Jul 21, 2024
3 checks passed
@lafriks lafriks deleted the option-to-semver-sort branch July 21, 2024 14:46
@woodpecker-bot woodpecker-bot mentioned this pull request Jul 21, 2024
1 task
@woodpecker-bot
Copy link
Contributor

🎉 This PR is included in version 1.2.0 🎉

The release is now available here

Thank you for your contribution. ❤️📦🚀

@@ -65,6 +65,7 @@ export const defaultUserConfig: UserConfig = {
skipLabels: ['skip-release', 'skip-changelog', 'regression'],
skipCommitsWithoutPullRequest: true,
commentOnReleasedPullRequests: true,
sortTags: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@6543 Why is there an option to disable this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you want the old behavior instead ... you could do so

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anbraten should I drop the config option and make it default?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its kind of a bugfix and I can't think why someone would want the other behavior, so I would just remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhance existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misspredict stop of last release
5 participants