-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to sort via semver before determin latest tag #146
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Untested from my side
🎉 This PR is included in version 1.2.0 🎉 The release is now available here Thank you for your contribution. ❤️📦🚀 |
@@ -65,6 +65,7 @@ export const defaultUserConfig: UserConfig = { | |||
skipLabels: ['skip-release', 'skip-changelog', 'regression'], | |||
skipCommitsWithoutPullRequest: true, | |||
commentOnReleasedPullRequests: true, | |||
sortTags: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@6543 Why is there an option to disable this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you want the old behavior instead ... you could do so
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anbraten should I drop the config option and make it default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think its kind of a bugfix and I can't think why someone would want the other behavior, so I would just remove it.
close #145