Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Release: 8.7.0 #7355

Merged
merged 18 commits into from
Oct 12, 2022
Merged

Release: 8.7.0 #7355

merged 18 commits into from
Oct 12, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 10, 2022

This is the release pull request for WooCommerce Blocks plugin 8.7.0.

Changelog


#### Enhancements

- Improve visual consistency between block links. ([7340](https://github.com/woocommerce/woocommerce-blocks/pull/7340))
- Update the titles of some inner blocks of the Cart block and remove the lock of the Cross-Sells parent block. ([7232](https://github.com/woocommerce/woocommerce-blocks/pull/7232))
- Add filter for place order button label. ([7154](https://github.com/woocommerce/woocommerce-blocks/pull/7154))
- Exposed data related to the checkout through wordpress/data stores. ([6612](https://github.com/woocommerce/woocommerce-blocks/pull/6612))
- Add simple, large & two menus footer patterns. ([7306](https://github.com/woocommerce/woocommerce-blocks/pull/7306))
- Add minimal, large, and essential header patterns. ([7292](https://github.com/woocommerce/woocommerce-blocks/pull/7292))
- Add `showRemoveItemLink` as a new checkout filter to allow extensions to toggle the visibility of the `Remove item` button under each cart line item. ([7242](https://github.com/woocommerce/woocommerce-blocks/pull/7242))
- Add support for a GT tracking ID for Google Analytics. ([7213](https://github.com/woocommerce/woocommerce-blocks/pull/7213))
- Separate filter titles and filter controls by converting filter blocks to use Inner Blocks. ([6978](https://github.com/woocommerce/woocommerce-blocks/pull/6978))
- StoreApi requests will return a `Cart-Token` header that can be used to retrieve the cart from the corresponding session via **GET** `/wc/store/v1/cart`. ([5953](https://github.com/woocommerce/woocommerce-blocks/pull/5953))



#### Bug Fixes

- Fixed HTML rendering in description of active payment integrations. ([7313](https://github.com/woocommerce/woocommerce-blocks/pull/7313))
- Hide the shipping address form from the Checkout when the "Force shipping to the customer billing address" is enabled. ([7268](https://github.com/woocommerce/woocommerce-blocks/pull/7268))
- Fixed an error where adding new pages would cause an infinite loop and large amounts of memory use in redux. ([7256](https://github.com/woocommerce/woocommerce-blocks/pull/7256))
- Ensure error messages containing HTML are shown correctly in the Cart and Checkout blocks. ([7231](https://github.com/woocommerce/woocommerce-blocks/pull/7231))
- Prevent locked inner blocks from sometimes displaying twice. ([6676](https://github.com/woocommerce/woocommerce-blocks/pull/6676))
- StoreApi `/checkout` endpoint now returns HTTP 402 instead of HTTP 400 when payment fails. ([7273](https://github.com/woocommerce/woocommerce-blocks/pull/7273))
- Fix a problem that causes an infinite loop when inserting Cart block in wordpress.com. ([7367](https://github.com/woocommerce/woocommerce-blocks/pull/7367))

Communication

Prepared Updates

Please leave a comment on this PR with links to the following:

  • Release announcement (announcement post on developer.woocommerce.com published after release).

  • Happiness engineering or Happiness/Support (if special instructions are needed).

  • Relevant developer documentation (if applicable).

Quality

This section is for things related to quality around the release.

  • Testing Instructions are included in this PR

  • Any performance impacts are documented.


🚀 This pull request was generated by the automations bot triggered by the creation of the branch: release/8.7.0. cc @wavvves

@github-actions
Copy link
Contributor Author

github-actions bot commented Oct 10, 2022

The release pull request has been created! This checklist is a guide to follow for the remainder of the release process. You can check off each item in this list once completed.

  • Checkout the release branch locally.

Initial Preparation

  • Close the milestone of the release you are going to ship. That will prevent newly approved PRs to be automatically assigned to that milestone.
  • Create a milestone for the next version.
  • Manually add the changelog entries of all affected PRs to readme.txt. (Technically, this should be an automated process, but it seems to broke recently. Please change this entry back, once the automated process works again.)
  • Ensure you pull your changes from the remote, since GitHub Actions will have added new commits to the branch.
    • Check the version and date in the changelog section within readme.txt, e.g. = 8.7.0 - YYYY-MM-DD =
    • Check the changelog matches the one in the pull request description above.
  • Update compatibility sections (if applicable). Note: Do not change the stable tag or plugin version; this is automated.
    • Update Requires at least, Tested up to, and Requires PHP sections at the top of readme.txt. Note, this should also be the latest WordPress version available at time of release.
    • Update Requires at least, Requires PHP, WC requires at least, and WC tested up to at the top of woocommerce-gutenberg-products-block.php. Note, this should include requiring the latest WP version at the time of release. For WC requires at least, use L1 (we publicly communicate L0 but technically support L1 to provide some space for folks to update). So this means if the current version of WooCommerce core is 5.8.0, then you'll want to put 5.7.0 here.
    • If necessary, update the value of $minimum_wp_version at the top of the woocommerce-gutenberg-products-block.php file to the latest available version of WordPress.
    • If necessary, update the phpcs.xml file to reference the minimum WP version supported by WooCommerce Core. It would be this line: <config name="minimum_supported_wp_version" value="5.6" />.
  • Push above changes to the release branch.

Create the Testing Notes

  • Run npm ci
  • Run npm run package-plugin:deploy. This will create a zip of the current branch build locally.
    • Note: The zip file is functionally equivalent to what gets released except the version bump.
  • Create the testing notes for the release.
    • For each pull request that belongs to the current release, grab the User Facing Testing notes from the PR's description. Be sure that the Do not include in the Testing Notes is not flagged checkbox is unchecked.
    • Add the notes to docs/internal-developers/testing/releases
    • Update the docs/internal-developers/testing/releases/README.md file index.
  • Copy a link to the release zip you created earlier into the testing notes. To generate the link you can upload the zip as an attachment in a GitHub comment and then just copy the path (without publishing the comment).
  • Commit and push the testing docs to the release branch.
  • Smoke test built release zip using the testing instructions you created:
    • Test in a clean environment, e.g. Jurassic.Ninja site.
    • Test existing WooCommerce Blocks content works correctly after update (no block validation errors).
    • Test to confirm blocks are available and work correctly in oldest supported WordPress version (e.g. 5.3).
    • Confidence check - check blocks are available and function.
    • Test to confirm new features/fixes are working correctly.
    • Test any UI changes in mobile and desktop views.
    • Smoke test – test a cross section of core functionality.
  • Ask the porters of Rubik and Kirigami to test the built zip as well and to approve the PR if everything looks good.

Each porter is responsible for testing the PRs that fall under the focus of their own team. Shared functionality should be tested by both porters. This means that the Rubik porter will mostly test checkout blocks and Store API endpoints, while the Kirigami porter will test the product related blocks and Store API endpoints.

  • If all PRs are testing as expected, continue with the release.
  • If one or more PRs are not testing as expected: ping the PR authors and the porter of the relevant team and ask them if the change is a release blocker or not (you can also ping the team lead if any of them is not available). In general, if it's not a regression or there is no product/marketing reason why that PR is a blocker, all other PRs should default to not being blockers.
    • If there are blockers: stop the release and ask the PR author to fix them. If the PR author is AFK, ping the porter of their team.
    • If some PRs are not testing as expected but they are not blockers: revert the relevant commits, remove the changes from testing steps and changelog, open an issue (or reopen the original one) and proceed with the release.
    • If minor issues are discovered during the testing, each team is responsible for logging them in Github.

Update Pull Request description and get approvals

  • Go through the description of the release pull request and edit it to update all the sections and checklist instructions there.

Ensure hub is set up and you're authenticated

  • Make sure you've got hub installed (brew install hub)
  • Make sure hub api user returns JSON with information about your GitHub user account, if it doesn't:
    • Create a GitHub access token with the repo permission.
    • Set the environment variables: GITHUB_USERNAME with your GitHub Username, and GITHUB_TOKEN with the token you just generated. (You may want to add these to .bashrc or the equivalent)
    • Run hub api user again and ensure JSON with information about your GitHub user account is returned.

Push the button - Deploy!

  • Execute npm run deploy
    • The script will ask you to enter the version number to tag. Please enter the version we're releasing right now. Do not publish any dev tags as a release.
    • Note: the script automatically updates version numbers on Github (commits on your behalf).
    • ALERT: This script will ask you if this release will be deployed to WordPress.org. You should answer yes for this release even if it is a pre-release.
    • A GitHub release will automatically be created and this will trigger a workflow that automatically deploys the plugin to WordPress.org.

If this release is deployed to WordPress.org...

  • An email confirmation is required before the new version will be released, so check your email in order to confirm the release.
  • Edit the GitHub release and copy changelog into the release notes. Ensure there is a release with the correct version, the one you entered above.
  • The #woo-blocks-repo slack instance will be notified about the progress with the WordPress.org deploy. Watch for that. If anything goes wrong, an error will be reported and you can followup via the GitHub actions tab and the log for that workflow.
  • After the wp.org workflow completes, confirm the following

After Workflow completes

  • Merge this pull request back into trunk. This may have merge conflicts needing resolved if there are any cherry-picked commits in the release branch.
  • Update version on the trunk branch to be for the next version of the plugin and include the dev suffix (e.g. something like 2.6-dev) for the next version. Be sure to update the version number in the following files:
    • package-lock.json
    • package.json
    • readme.txt
    • src/Package.php
    • woocommerce-gutenberg-products-block.php.
  • Update the schedules p2 with the shipped date for the release (PdToLP-K-p2).
  • Edit the GitHub milestone of the release you just shipped and add the current date as the due date (this is used to track ship date as well).

Pull request in WooCommerce Core for Package update

This only needs to be done if this release is the last release of the feature plugin before code freeze in the WooCommerce core cycle. If this condition doesn't exist you can skip this section.

  • Remind whoever is porter this week to audit our codebase to ensure this experimental interface document is up to date. See Pca54o-rM-p2 for more details.
  • Create a pull request for updating the package in the WooCommerce Core Repository that bumps the package version for the Woo Blocks package to the version you are releasing.
    • The content for the pull release can follow this example.

      • Increase the version of woocommerce/woocommerce-blocks in the plugins/woocommerce/composer.json file

      • Run composer update woocommerce/woocommerce-blocks and make sure composer-lock.json was updated

      • Add a new file similar to this one plugins/woocommerce/changelog/update-woocommerce-blocks-7.4.1 with a similar content as below. For the Significance entry we’ll always use minor, or patch when including a patch release

        ```
        Significance: minor
        Type: update
        
        Update WooCommerce Blocks to 7.4.1
        ```
        
    • The PR description can follow this example.

      • It lists all the WooCommerce Blocks versions that are being included since the last version that you edited in plugins/woocommerce/composer.json. Each version should have a link for the Release PR, Testing instructions and Release post (if available).
      • The changelog should be aggregated from all the releases included in the package bump and grouped per type: Enhancements, Bug Fixes, Various etc. This changelog will be used in the release notes for the WooCommerce release. That's why it should only list the PRs that have WooCoomerce Core in the WooCommerce Visibility section of their description. Don't include changes available in the feature plugin or development builds.
    • Run through the testing checklist to ensure everything works in that branch for that package bump. Note: Testing should ensure any features/new blocks that are supposed to be behind feature gating for the core merge of this package update are working as expected.

    • Testing should include completing the Smoke testing checklist. It's up to you to verify that those tests have been done.

    • Verify and make any additional edits to the pull request description for things like: Changelog to be included with WooCommerce core, additional communication that might be needed elsewhere, additional marketing communication notes that may be needed, etc.

    • After the checklist is complete and the testing is done, select the porter of your team to review the PR. Once approved, make sure you merge the PR.

  • Make sure you join the #woo-core-releases Slack channel to represent Woo Blocks for the release of WooCommerce core this version is included in.
  • Search the release thread of the WooCommerce core version in WooCommerce P2 (example: p6q8Tx-2gl-p2).
    • Subscribe to it, so you are aware of any news/changes.
    • Make sure you are listed as the Blocks Package lead or add yourself if you aren't.
    • Add changes you want to highlight under the Feature Rollup comment. Please also look at changes from earlier versions that we didn't include in WC core yet. Ping the porters if you are unsure.

Publish posts

  • Post release announcement on WooCommerce Developer Blog.
    • Ping porters from each team to know which changelog entries need to be highlighted. Ask them to write a short text and optionally provide a screenshot. They can use previous posts for inspiration, we usually try to highlight new features or API changes.
    • Ensure the release notes are included in the post verbatim.
    • Don't forget to use category WooCommerce Blocks Release Notes for the post.
  • Announce the release internally (#woo-announcements slack).
  • Update user-facing documentation as needed. When the plugin is released, ensure user-facing documentation is kept up to date with new blocks and compatibility information. The dev team should update documents in collaboration with support team and WooCommerce docs guild. In particular, please review and update as needed:
    • Are there any new blocks in this release? Ensure they have adequate user documentation.
    • Ensure any major improvements or changes are documented.
    • Update minimum supported versions (WordPress, WooCommerce Core) and other requirements where necessary, including:
🚀 This comment was generated by the automations bot triggered by the creation of the branch: release/8.7.0. cc @wavvves

@github-actions
Copy link
Contributor Author

The release ZIP for this PR is accessible via:

https://wcblocks.wpcomstaging.com/wp-content/uploads/woocommerce-gutenberg-products-block-7355.zip

@github-actions
Copy link
Contributor Author

github-actions bot commented Oct 10, 2022

Size Change: +2.76 kB (0%)

Total Size: 962 kB

Filename Size Change
build/active-filters-frontend.js 7.72 kB -11 B (0%)
build/active-filters-wrapper-frontend.js 6.01 kB -5 B (0%)
build/active-filters.js 7.44 kB -29 B (0%)
build/all-products-frontend.js 26.5 kB -12 B (0%)
build/all-products.js 33.6 kB -19 B (0%)
build/all-reviews.js 7.79 kB +5 B (0%)
build/attribute-filter-frontend.js 22.5 kB +12 B (0%)
build/attribute-filter-wrapper-frontend.js 7.04 kB +10 B (0%)
build/attribute-filter.js 12.4 kB +3 B (0%)
build/cart-blocks/cart-cross-sells-products--product-add-to-cart-frontend.js 5.63 kB -2 B (0%)
build/cart-blocks/cart-cross-sells-products-frontend.js 4.66 kB -2 B (0%)
build/cart-blocks/cart-express-payment--checkout-blocks/express-payment-frontend.js 5.23 kB -2 B (0%)
build/cart-blocks/cart-express-payment-frontend.js 784 B -2 B (0%)
build/cart-blocks/cart-line-items--mini-cart-contents-block/products-table-frontend.js 5.3 kB -3 B (0%)
build/cart-blocks/order-summary-coupon-form-frontend.js 2.73 kB -2 B (0%)
build/cart-blocks/order-summary-discount-frontend.js 2.16 kB +3 B (0%)
build/cart-blocks/order-summary-shipping--checkout-blocks/order-summary-shipping-frontend.js 6.61 kB +1 B (0%)
build/cart-frontend.js 50 kB +12 B (0%)
build/cart.js 46.2 kB -2 B (0%)
build/checkout-blocks/billing-address--checkout-blocks/shipping-address-frontend.js 4.98 kB -1 B (0%)
build/checkout-blocks/contact-information-frontend.js 3.03 kB +1 B (0%)
build/checkout-blocks/order-summary-cart-items-frontend.js 3.67 kB +2 B (0%)
build/checkout-blocks/order-summary-coupon-form-frontend.js 2.88 kB -1 B (0%)
build/checkout-blocks/order-summary-discount-frontend.js 2.28 kB +2 B (0%)
build/checkout-blocks/order-summary-frontend.js 1.11 kB +1 B (0%)
build/checkout-blocks/payment-frontend.js 8 kB +1 B (0%)
build/checkout-blocks/shipping-methods-frontend.js 4.89 kB -1 B (0%)
build/checkout-blocks/terms-frontend.js 1.64 kB -3 B (0%)
build/checkout-frontend.js 52.1 kB +7 B (0%)
build/checkout.js 40 kB +1 B (0%)
build/featured-category.js 13.2 kB -11 B (0%)
build/featured-product.js 13.4 kB -8 B (0%)
build/filter-wrapper-frontend.js 10.6 kB -5 B (0%)
build/handpicked-products.js 7.27 kB -13 B (0%)
build/legacy-template.js 2.84 kB +3 B (0%)
build/mini-cart-component-frontend.js 16.8 kB +3 B (0%)
build/mini-cart-contents-block/footer-frontend.js 2.98 kB +3 B (0%)
build/mini-cart-contents-block/products-table-frontend.js 590 B +1 B (0%)
build/mini-cart-contents.js 16.8 kB +3 B (0%)
build/mini-cart-frontend.js 1.71 kB -1 B (0%)
build/price-filter-frontend.js 13.6 kB -3 B (0%)
build/price-filter-wrapper-frontend.js 6.95 kB +1 B (0%)
build/product-add-to-cart--product-button--product-image--product-title.js 2.66 kB -2 B (0%)
build/product-button--product-image--product-rating--product-sale-badge--product-title.js 302 B -1 B (0%)
build/product-button.js 1.58 kB +1 B (0%)
build/product-categories.js 2.36 kB +1 B (0%)
build/product-category-list-frontend.js 882 B +1 B (0%)
build/product-category-list.js 502 B -1 B (0%)
build/product-image-frontend.js 1.92 kB +1 B (0%)
build/product-image.js 1.62 kB +2 B (0%)
build/product-new.js 7.62 kB -4 B (0%)
build/product-on-sale.js 7.95 kB +3 B (0%)
build/product-price-frontend.js 1.92 kB +1 B (0%)
build/product-price.js 1.53 kB +1 B (0%)
build/product-rating-frontend.js 1.18 kB +1 B (0%)
build/product-rating.js 773 B -1 B (0%)
build/product-sale-badge-frontend.js 1.15 kB +2 B (0%)
build/product-sale-badge.js 819 B +4 B (0%)
build/product-search.js 2.61 kB -2 B (0%)
build/product-stock-indicator-frontend.js 997 B +1 B (0%)
build/product-summary-frontend.js 1.29 kB +1 B (0%)
build/product-summary.js 920 B +1 B (0%)
build/product-tag-list-frontend.js 878 B +2 B (0%)
build/product-tag-list.js 496 B -1 B (0%)
build/product-tag.js 8 kB +4 B (0%)
build/product-title-frontend.js 1.34 kB +2 B (0%)
build/product-title.js 938 B +1 B (0%)
build/product-top-rated.js 7.86 kB -3 B (0%)
build/rating-filter-frontend.js 7.39 kB +656 B (+10%) ⚠️
build/rating-filter.js 7.87 kB +2.22 kB (+39%) 🚨
build/reviews-by-category.js 11.2 kB +6 B (0%)
build/reviews-by-product.js 12.3 kB +1 B (0%)
build/reviews-frontend.js 7 kB +2 B (0%)
build/single-product-frontend.js 29.2 kB +2 B (0%)
build/single-product.js 10 kB +4 B (0%)
build/stock-filter-frontend.js 7.72 kB -6 B (0%)
build/stock-filter-wrapper-frontend.js 5.99 kB -2 B (0%)
build/stock-filter.js 6.65 kB -31 B (0%)
build/vendors--attribute-filter-wrapper--mini-cart-contents-block/footer-frontend.js 6.86 kB +1 B (0%)
build/wc-blocks-style-rtl.css 24.2 kB -19 B (0%)
build/wc-blocks-style.css 24.1 kB -25 B (0%)
build/wc-blocks-vendors.js 62.4 kB -1 B (0%)
ℹ️ View Unchanged
Filename Size
build/blocks-checkout.js 17.5 kB
build/cart-blocks/cart-accepted-payment-methods-frontend.js 1.38 kB
build/cart-blocks/cart-cross-sells-frontend.js 253 B
build/cart-blocks/cart-items-frontend.js 298 B
build/cart-blocks/cart-line-items-frontend.js 1.07 kB
build/cart-blocks/cart-order-summary-frontend.js 1.11 kB
build/cart-blocks/cart-totals-frontend.js 320 B
build/cart-blocks/empty-cart-frontend.js 346 B
build/cart-blocks/filled-cart-frontend.js 785 B
build/cart-blocks/order-summary-fee-frontend.js 273 B
build/cart-blocks/order-summary-heading-frontend.js 454 B
build/cart-blocks/order-summary-shipping-frontend.js 430 B
build/cart-blocks/order-summary-subtotal-frontend.js 274 B
build/cart-blocks/order-summary-taxes-frontend.js 435 B
build/cart-blocks/proceed-to-checkout-frontend.js 1.19 kB
build/checkout-blocks/actions-frontend.js 1.79 kB
build/checkout-blocks/billing-address-frontend.js 948 B
build/checkout-blocks/express-payment-frontend.js 1.16 kB
build/checkout-blocks/fields-frontend.js 344 B
build/checkout-blocks/order-note-frontend.js 1.14 kB
build/checkout-blocks/order-summary-fee-frontend.js 276 B
build/checkout-blocks/order-summary-shipping-frontend.js 603 B
build/checkout-blocks/order-summary-subtotal-frontend.js 273 B
build/checkout-blocks/order-summary-taxes-frontend.js 435 B
build/checkout-blocks/shipping-address-frontend.js 1.06 kB
build/checkout-blocks/totals-frontend.js 323 B
build/filter-wrapper.js 1.86 kB
build/general-style-rtl.css 1.29 kB
build/general-style.css 1.29 kB
build/mini-cart-contents-block/empty-cart-frontend.js 367 B
build/mini-cart-contents-block/filled-cart-frontend.js 230 B
build/mini-cart-contents-block/items-frontend.js 236 B
build/mini-cart-contents-block/shopping-button-frontend.js 287 B
build/mini-cart-contents-block/title-frontend.js 367 B
build/mini-cart.js 4.57 kB
build/price-filter.js 8.47 kB
build/price-format.js 1.19 kB
build/product-add-to-cart--product-button--product-category-list--product-image--product-price--product-r--a0326d00.js 227 B
build/product-add-to-cart-frontend.js 1.25 kB
build/product-add-to-cart.js 6.47 kB
build/product-best-sellers.js 7.62 kB
build/product-button--product-category-list--product-image--product-price--product-rating--product-sale-b--e17c7c01.js 433 B
build/product-button-frontend.js 1.89 kB
build/product-category.js 8.61 kB
build/product-query.js 648 B
build/product-sku-frontend.js 379 B
build/product-sku.js 380 B
build/product-stock-indicator.js 624 B
build/products-by-attribute.js 8.53 kB
build/vendors--attribute-filter-wrapper-frontend.js 8.21 kB
build/vendors--cart-blocks/cart-cross-sells-products--cart-blocks/cart-line-items--cart-blocks/cart-order--671ca56f-frontend.js 5.26 kB
build/vendors--cart-blocks/cart-cross-sells-products--cart-blocks/order-summary-shipping--checkout-blocks--18f9376a-frontend.js 19.1 kB
build/vendors--cart-blocks/cart-cross-sells-products--product-add-to-cart-frontend.js 7.53 kB
build/vendors--cart-blocks/cart-line-items--checkout-blocks/order-summary-cart-items--mini-cart-contents---233ab542-frontend.js 3.14 kB
build/vendors--cart-blocks/order-summary-shipping--checkout-blocks/billing-address--checkout-blocks/order--5b8feb0b-frontend.js 4.85 kB
build/wc-blocks-data.js 15.9 kB
build/wc-blocks-editor-style-rtl.css 5.24 kB
build/wc-blocks-editor-style.css 5.24 kB
build/wc-blocks-google-analytics.js 1.56 kB
build/wc-blocks-middleware.js 932 B
build/wc-blocks-registry.js 2.92 kB
build/wc-blocks-shared-context.js 1.52 kB
build/wc-blocks-shared-hocs.js 1.72 kB
build/wc-blocks-vendors-style-rtl.css 1.95 kB
build/wc-blocks-vendors-style.css 1.95 kB
build/wc-blocks.js 2.62 kB
build/wc-payment-method-bacs.js 816 B
build/wc-payment-method-cheque.js 811 B
build/wc-payment-method-cod.js 909 B
build/wc-payment-method-paypal.js 837 B
build/wc-settings.js 2.6 kB

compressed-size-action

@wavvves wavvves self-assigned this Oct 10, 2022
thealexandrelara and others added 12 commits October 10, 2022 18:34
* Set default style to link-button mixin

It was identified that we currently have 3 different behaviors for links used in the application. In issue #1778, it was discussed a set of good practices that we should follow in order to obtain consistency between links.

Currently, the link-button mixin is already used by the 'Clear all' button in the Active Filters block, so the idea was to increment it with a common pattern (font size small, font-weight normal, underlined by default and not underlined when on hover) that can be reused by other components (for example FilterResetButton).

* Change link-button mixin to make it attend the expected default style for links

* Replace text-button with link-button mixin in FilterResetButton component

* Add new mixin for links in filter blocks

* Revert change to link-button mixin to prevent it to affect link buttons on Checkout page

* Add filter-link-button mixin that can be used in filter blocks

* Remove link-button styles that were moved to filter-link-button mixin

By default, link-button mixin styles should have only styles from the text-button mixin and also be underlined.

The styles for link button in filter blocks should reside in filter-link-button mixin.
* Correct block name and description

* remove duplicated description for controls blocks

* remove duplicated title and desc

* Revert "remove duplicated description for controls blocks"

This reverts commit ed5417e.
…#7367)

* remove problematic actions as deps

* add inline docs

* add todo comment
@wavvves
Copy link
Contributor

wavvves commented Oct 11, 2022

Updated test zip:

woocommerce-gutenberg-products-block.zip

Copy link
Member

@alexflorisca alexflorisca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wavvves wavvves merged commit 6547881 into trunk Oct 12, 2022
@wavvves wavvves deleted the release/8.7.0 branch October 12, 2022 10:03
@wavvves wavvves restored the release/8.7.0 branch October 12, 2022 10:03
sunyatasattva pushed a commit that referenced this pull request Oct 26, 2022
* Empty commit for release pull request

* Updated changelog.

* Minor lint fix.

* 8.7.0 Testing instructions

* Updated and tidy docs/internal-developers/testing/releases/README.md

* Add filter-link-button mixin (#7357)

* Set default style to link-button mixin

It was identified that we currently have 3 different behaviors for links used in the application. In issue #1778, it was discussed a set of good practices that we should follow in order to obtain consistency between links.

Currently, the link-button mixin is already used by the 'Clear all' button in the Active Filters block, so the idea was to increment it with a common pattern (font size small, font-weight normal, underlined by default and not underlined when on hover) that can be reused by other components (for example FilterResetButton).

* Change link-button mixin to make it attend the expected default style for links

* Replace text-button with link-button mixin in FilterResetButton component

* Add new mixin for links in filter blocks

* Revert change to link-button mixin to prevent it to affect link buttons on Checkout page

* Add filter-link-button mixin that can be used in filter blocks

* Remove link-button styles that were moved to filter-link-button mixin

By default, link-button mixin styles should have only styles from the text-button mixin and also be underlined.

The styles for link button in filter blocks should reside in filter-link-button mixin.

* Cherry picked Add filter-link-button mixin #7357 and updated testing instructions

* Re-added #7273 to changelog

* Correct block name and description (#7354)

* Correct block name and description

* remove duplicated description for controls blocks

* remove duplicated title and desc

* Revert "remove duplicated description for controls blocks"

This reverts commit ed5417e.

* removed #7338 from testing instructions and changelog

* Updated testing zip package.

* Minor formatting fix on the release instructions

* change any to or below the express payment method on cart (#7369)

* Updated zip.

* Add temporary workaround to fix inserting Cart block in WordPress.com (#7367)

* remove problematic actions as deps

* add inline docs

* add todo comment

* Cherry picked: Fix a problem that causes an infinite loop when inserting Cart block in wordpress.com (7367)

* Updated testing zip.

Co-authored-by: github-actions <[email protected]>
Co-authored-by: Paulo Arromba <[email protected]>
Co-authored-by: Alexandre Lara <[email protected]>
Co-authored-by: Tung Du <[email protected]>
Co-authored-by: Alex Florisca <[email protected]>
Co-authored-by: Seghir Nadir <[email protected]>
senadir added a commit to senadir/woocommerce-blocks that referenced this pull request Nov 12, 2022
* Empty commit for release pull request

* Updated changelog.

* Minor lint fix.

* 8.7.0 Testing instructions

* Updated and tidy docs/internal-developers/testing/releases/README.md

* Add filter-link-button mixin (woocommerce#7357)

* Set default style to link-button mixin

It was identified that we currently have 3 different behaviors for links used in the application. In issue woocommerce#1778, it was discussed a set of good practices that we should follow in order to obtain consistency between links.

Currently, the link-button mixin is already used by the 'Clear all' button in the Active Filters block, so the idea was to increment it with a common pattern (font size small, font-weight normal, underlined by default and not underlined when on hover) that can be reused by other components (for example FilterResetButton).

* Change link-button mixin to make it attend the expected default style for links

* Replace text-button with link-button mixin in FilterResetButton component

* Add new mixin for links in filter blocks

* Revert change to link-button mixin to prevent it to affect link buttons on Checkout page

* Add filter-link-button mixin that can be used in filter blocks

* Remove link-button styles that were moved to filter-link-button mixin

By default, link-button mixin styles should have only styles from the text-button mixin and also be underlined.

The styles for link button in filter blocks should reside in filter-link-button mixin.

* Cherry picked Add filter-link-button mixin woocommerce#7357 and updated testing instructions

* Re-added woocommerce#7273 to changelog

* Correct block name and description (woocommerce#7354)

* Correct block name and description

* remove duplicated description for controls blocks

* remove duplicated title and desc

* Revert "remove duplicated description for controls blocks"

This reverts commit ed5417e.

* removed woocommerce#7338 from testing instructions and changelog

* Updated testing zip package.

* Minor formatting fix on the release instructions

* change any to or below the express payment method on cart (woocommerce#7369)

* Updated zip.

* Add temporary workaround to fix inserting Cart block in WordPress.com (woocommerce#7367)

* remove problematic actions as deps

* add inline docs

* add todo comment

* Cherry picked: Fix a problem that causes an infinite loop when inserting Cart block in wordpress.com (7367)

* Updated testing zip.

Co-authored-by: github-actions <[email protected]>
Co-authored-by: Paulo Arromba <[email protected]>
Co-authored-by: Alexandre Lara <[email protected]>
Co-authored-by: Tung Du <[email protected]>
Co-authored-by: Alex Florisca <[email protected]>
Co-authored-by: Seghir Nadir <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants