-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Jetpack Setup] Update magic link handling to work with the Connection API integration #13686
base: issue/13665-jetpack-connection-api-cookies
Are you sure you want to change the base?
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍🏻 It works with both the new login and Jetpack connection flow from Settings.
Closes: #13666
Description
This PR fixes magic link handling to ensure we use the Connection API when it's available, the change means we will fetch the connection status when handling the magic link, instead of relying on the
source
argument that we were using before.While this is now a bit more complicated, it also ensures the experience is more robust, as now we ensure we use the correct
JetpackStatus
at the time of the magic link handling, where before, there could be cases where the user modify their website before clicking on the magic link, and leading to issues.Steps to reproduce
Perform TC6 from pe5sF9-42S-p2
Testing information
Confirm that the app uses the Connection API.
The tests that have been performed
^
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: