-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Woo POS] Add public-facing documentation link to POS popup menu #13466
[Woo POS] Add public-facing documentation link to POS popup menu #13466
Conversation
NOTE: The Exact URL needs to be finalised
…S documentation menu option
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #13466 +/- ##
=========================================
Coverage 37.89% 37.89%
- Complexity 8957 8959 +2
=========================================
Files 2050 2050
Lines 112086 112104 +18
Branches 14172 14174 +2
=========================================
+ Hits 42477 42486 +9
- Misses 65730 65739 +9
Partials 3879 3879 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AnirudhBhat! Works as expected. I've left a couple minor comments, feel free to merge this.
@@ -239,7 +249,7 @@ private fun PopUpMenu( | |||
onClick: (Menu.MenuItem) -> Unit | |||
) { | |||
WooPosCard( | |||
modifier = modifier.width(214.dp), | |||
modifier = modifier.width(254.dp), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Feels a bit off to hardcode a specific value, considering we don't know what font size and language the user will be using. What do you think about setting max-width instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I've made it dynamic here: 88ee6c8
I've optimised the icon here: 88ee6c8 |
Closes: #13454
NOTE: The POS documentation link currently returns a 404, but it is planned to be ready before the public release.
Description
This PR introduces a new popup menu item in the POS interface that allows users to access public-facing documentation. Currently, a placeholder URL is used as the final URL is yet to be finalised.
Discussion: p91TBi-cNJ-p2#comment-13978
Changes
Testing information
The tests that have been performed
Tested both on Light and Dark mode
Images/gif
Screen_recording_20250205_100820.mp4
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: