Fix budget slider responsiveness #10739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
JorgeMucientes
commented
Feb 9, 2024
| @@ -192,7 +195,6 @@ class BlazeCampaignBudgetViewModel @Inject constructor( | |||
| data class BudgetUiState( | |||
| val currencyCode: String, | |||
| val totalBudget: Float, | |||
| val sliderValue: Float, | |||
There was a problem hiding this comment.
The new approach is simpler and doesn't require to have 2 different values, one for the budget and other for the slider position
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Generated by 🚫 Danger |
JorgeMucientes
added
the
status: do not merge
0nko
approved these changes
Feb 9, 2024
JorgeMucientes
removed
the
status: do not merge
Generated by 🚫 dangerJS |
# Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/blaze/creation/budget/BlazeCampaignBudgetViewModel.kt
JorgeMucientes
deleted the
issue/10574-fix-budget-slider-responsiveness
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #10574
Description
These small changes fix several issues with the budget slider responsiveness. Issues are described in this PR: #10709 (comment)
Testing instructions
Images/gif
alwaysShowMultipleOfDuration.mp4