-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Jetpack CP login #10688
Fix Jetpack CP login #10688
Conversation
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release/17.2 #10688 +/- ##
===============================================
Coverage 41.57% 41.57%
+ Complexity 5009 5008 -1
===============================================
Files 1010 1010
Lines 58068 58067 -1
Branches 7735 7734 -1
===============================================
+ Hits 24140 24141 +1
Misses 31783 31783
+ Partials 2145 2143 -2 ☔ View full report in Codecov by Sentry. |
0648600
to
2c6baa5
Compare
This was a great find @hichamboushaba ! I really hope it helps reduce the number of users having trouble connecting to their stores. PS: Tested it and login for jetpack CP sites works as expected |
@hichamboushaba This PR is included in the |
Description
This commit b28e928 that removed the Jetpack CP feature flag accidentally broke the Jetpack CP login, as it filtered out all of the JetpackCPConnected sites from the site picker's logic.
This PR fixes this.
This was identified after investigating this p1707195959834669/1705664280.448529-slack-C03L1NF1EA3
Testing instructions
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.