Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Jetpack CP login #10688

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Fix Jetpack CP login #10688

merged 2 commits into from
Feb 6, 2024

Conversation

hichamboushaba
Copy link
Member

@hichamboushaba hichamboushaba commented Feb 6, 2024

Description

This commit b28e928 that removed the Jetpack CP feature flag accidentally broke the Jetpack CP login, as it filtered out all of the JetpackCPConnected sites from the site picker's logic.
This PR fixes this.

This was identified after investigating this p1707195959834669/1705664280.448529-slack-C03L1NF1EA3

Testing instructions

  1. Create a Jetpack CP site.
  2. Confirm login works correctly to this site.
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

@hichamboushaba hichamboushaba added type: bug A confirmed bug. feature: login Related to any part of the log in or sign in flow, or authentication. labels Feb 6, 2024
@JorgeMucientes JorgeMucientes self-assigned this Feb 6, 2024
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Feb 6, 2024

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
FlavorJalapeno
Build TypeDebug
Commit2c6baa5
Direct Downloadwoocommerce-prototype-build-pr10688-2c6baa5.apk

@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (37c6ea8) 41.57% compared to head (2c6baa5) 41.57%.

Files Patch % Lines
...merce/android/ui/sitepicker/SitePickerViewModel.kt 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##             release/17.2   #10688   +/-   ##
===============================================
  Coverage           41.57%   41.57%           
+ Complexity           5009     5008    -1     
===============================================
  Files                1010     1010           
  Lines               58068    58067    -1     
  Branches             7735     7734    -1     
===============================================
+ Hits                24140    24141    +1     
  Misses              31783    31783           
+ Partials             2145     2143    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hichamboushaba hichamboushaba changed the base branch from trunk to release/17.2 February 6, 2024 10:11
@hichamboushaba hichamboushaba marked this pull request as ready for review February 6, 2024 10:11
@dangermattic
Copy link
Collaborator

dangermattic commented Feb 6, 2024

1 Warning
⚠️ This PR is assigned to the milestone 17.2 ❄️. The due date for this milestone has already passed.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@hichamboushaba hichamboushaba requested a review from 0nko February 6, 2024 10:11
@hichamboushaba hichamboushaba added this to the 17.2 ❄️ milestone Feb 6, 2024
@JorgeMucientes
Copy link
Contributor

JorgeMucientes commented Feb 6, 2024

This was a great find @hichamboushaba ! I really hope it helps reduce the number of users having trouble connecting to their stores. :shipit:

PS: Tested it and login for jetpack CP sites works as expected

@JorgeMucientes JorgeMucientes merged commit ffd7c59 into release/17.2 Feb 6, 2024
16 of 19 checks passed
@JorgeMucientes JorgeMucientes deleted the fix-jetpack-cp-login branch February 6, 2024 11:02
@spencertransier
Copy link
Contributor

@hichamboushaba This PR is included in the 17.2-rc-2 build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: login Related to any part of the log in or sign in flow, or authentication. type: bug A confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants