Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blaze: Ad destination screen #10685

Merged
merged 5 commits into from
Feb 7, 2024
Merged

Conversation

0nko
Copy link
Contributor

@0nko 0nko commented Feb 5, 2024

Implements #10684, a subtask of #10665.

To test:

  1. Start a Blaze campaign
  2. Select a product
  3. Tap on Promote button
  4. Tap on Ad destination
  5. Notice the Ad destination screen is opened

@0nko 0nko added feature: blaze Related to the Blaze project unit-tests-exemption labels Feb 5, 2024
@0nko 0nko added this to the 17.3 milestone Feb 5, 2024
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ Class BlazeCampaignCreationAdDestinationViewModel is missing tests, but unit-tests-exemption label was set to ignore this.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Feb 5, 2024

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
FlavorJalapeno
Build TypeDebug
Commit480c291
Direct Downloadwoocommerce-prototype-build-pr10685-480c291.apk

@JorgeMucientes JorgeMucientes self-assigned this Feb 6, 2024
# Conflicts:
#	WooCommerce/src/main/kotlin/com/woocommerce/android/ui/blaze/creation/preview/BlazeCampaignCreationPreviewFragment.kt
#	WooCommerce/src/main/kotlin/com/woocommerce/android/ui/blaze/creation/preview/BlazeCampaignCreationPreviewViewModel.kt
#	WooCommerce/src/main/res/navigation/nav_graph_blaze_campaign_creation.xml
#	WooCommerce/src/main/res/values/strings.xml
@codecov-commenter
Copy link

Codecov Report

Attention: 223 lines in your changes are missing coverage. Please review.

Comparison is base (7d59059) 41.56% compared to head (480c291) 41.44%.
Report is 21 commits behind head on trunk.

Files Patch % Lines
...s/BlazeCampaignTargetLocationSelectionViewModel.kt 0.00% 92 Missing ⚠️
...blaze/creation/targets/TargetSelectionViewState.kt 0.00% 37 Missing ⚠️
...n/preview/BlazeCampaignCreationPreviewViewModel.kt 0.00% 24 Missing ⚠️
...om/woocommerce/android/ui/blaze/BlazeRepository.kt 0.00% 22 Missing ⚠️
...n/targets/BlazeCampaignTargetSelectionViewModel.kt 0.00% 19 Missing ⚠️
...ion/BlazeCampaignCreationAdDestinationViewModel.kt 0.00% 15 Missing ⚠️
...m/woocommerce/android/extensions/FlowExtensions.kt 0.00% 8 Missing ⚠️
...blaze/creation/targets/TargetSelectionViewModel.kt 0.00% 3 Missing ⚠️
...ce/android/ui/compose/component/MultiSelectList.kt 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #10685      +/-   ##
============================================
- Coverage     41.56%   41.44%   -0.13%     
  Complexity     5009     5009              
============================================
  Files          1010     1014       +4     
  Lines         58071    58242     +171     
  Branches       7735     7752      +17     
============================================
  Hits          24140    24140              
- Misses        31786    31957     +171     
  Partials       2145     2145              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JorgeMucientes
Copy link
Contributor

Nice work, @0nko; the code looks good and works as expected.

@JorgeMucientes JorgeMucientes merged commit 92810a2 into trunk Feb 7, 2024
15 checks passed
@JorgeMucientes JorgeMucientes deleted the issue/10684-ad-destination-screen branch February 7, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: blaze Related to the Blaze project unit-tests-exemption
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants