-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blaze: Ad destination screen #10685
Blaze: Ad destination screen #10685
Conversation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
# Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/blaze/creation/preview/BlazeCampaignCreationPreviewFragment.kt # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/blaze/creation/preview/BlazeCampaignCreationPreviewViewModel.kt # WooCommerce/src/main/res/navigation/nav_graph_blaze_campaign_creation.xml # WooCommerce/src/main/res/values/strings.xml
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## trunk #10685 +/- ##
============================================
- Coverage 41.56% 41.44% -0.13%
Complexity 5009 5009
============================================
Files 1010 1014 +4
Lines 58071 58242 +171
Branches 7735 7752 +17
============================================
Hits 24140 24140
- Misses 31786 31957 +171
Partials 2145 2145 ☔ View full report in Codecov by Sentry. |
Nice work, @0nko; the code looks good and works as expected. |
Implements #10684, a subtask of #10665.
To test: