[Issue 3885] product variation delete confirmation dialog to a dialog fragment

[jd-alexander]

Closes: #3885

Description

This PR was created to address the issue where the confirmation dialog is dismissed upon device rotation in the VariationDetailFragment, some notable changes:

1. Reattaching the Listener: A method named reattachDialogInteractionListener was added to the VariationDetailFragment. This method is called within onViewCreated to re-establish the connection between the VariationDetailFragment and the WooDialogFragment. It checks if the dialog is currently displayed and, if so, sets the current instance of VariationDetailFragment as the listener to the dialog. This ensures that the dialog can continue to communicate with the active instance of the fragment after a configuration change.

2. Event Handling: The ViewModel was updated to handle the delete action through a ShowDialogFragment event. This event encapsulates all necessary information to display the dialog, including message IDs and button texts. When the event is triggered, the dialog is shown with the current context, and any actions taken in the dialog are communicated back to the ViewModel through the established listener interface.

3. Observing Lifecycle Events: The VariationDetailFragment observes the ShowDialogFragment event. If the fragment is recreated due to an orientation change, the observer ensures that the dialog is shown again with the correct listener attached.

Testing instructions

1. Click a production with multiple variations.
2. Click Variations.
3. Open a variation.
4. Click the menu option.
5. Press Delete.
6. See the dialog visible.
7. Rotate the device and realize that the dialog is still open.
8. Verify that the actions on the dialog work as expected.

Images/gif

Screen_Recording_20240131_175116_WooCommerce.Dev.mp4

• I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

[dangermattic]

	2 Warnings
⚠️	Class ShowDialogFragment is missing tests, but unit-tests-exemption label was set to ignore this.
⚠️	This PR is assigned to the milestone 17.3. This milestone is due in less than 2 days. Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

[wpmobilebot]

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Flavor	Jalapeno
	Build Type	Debug
	Commit	2b41899
	Direct Download	woocommerce-prototype-build-pr10664-2b41899.apk

[codecov-commenter]

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (92810a2) 41.47% compared to head (18094aa) 41.56%.

❗ Current head 18094aa differs from pull request most recent head 2b41899. Consider uploading reports for the commit 2b41899 to get more accurate results

Files	Patch %	Lines
.../com/woocommerce/android/ui/dialog/DialogParams.kt	0.00%	9 Missing ⚠️
...ui/products/variations/VariationDetailViewModel.kt	0.00%	9 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##              trunk   #10664      +/-   ##
============================================
+ Coverage     41.47%   41.56%   +0.09%     
+ Complexity     5016     5009       -7     
============================================
  Files          1015     1011       -4     
  Lines         58299    58075     -224     
  Branches       7793     7735      -58     
============================================
- Hits          24178    24140      -38     
+ Misses        31977    31790     -187     
- Partials       2144     2145       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[peril-woocommerce]

	Warnings
⚠️	This PR is assigned to a milestone which is closing in less than 2 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

[jd-alexander]

Hi @AnirudhBhat I've reviewed the PR requirements regarding Tracks-related updates. I want to clarify that my changes only involved moving existing Tracks logic to a new function, without altering its behavior or the events it triggers. Given this, I'm unsure if the full validation process in the Tracks system and updating the internal spreadsheet is necessary. Could you advise if these steps are still needed for such changes? Thanks for your guidance!

[AnirudhBhat]

Thanks for working on this @jd-alexander. Works as expected!

[AnirudhBhat]

Given this, I'm unsure if the full validation process in the Tracks system and updating the internal spreadsheet is necessary. Could you advise if these steps are still needed for such changes?

Sorry, I missed your comment. This PR does not require any modifications to the spreadsheet since it only involves reorganizing existing events, without adding or removing any.

[jd-alexander]

Given this, I'm unsure if the full validation process in the Tracks system and updating the internal spreadsheet is necessary. Could you advise if these steps are still needed for such changes?

Sorry, I missed your comment. This PR does not require any modifications to the spreadsheet since it only involves reorganizing existing events, without adding or removing any.

No problem! Thanks for chiming in. I appreciate it @AnirudhBhat