Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI Test] - Re-enable Create Order test #10660

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Conversation

jostnes
Copy link
Contributor

@jostnes jostnes commented Feb 1, 2024

Description

This PR re-enables the Create Order UI test that was temporarily disabled in #10035 (comment) because of screen changes and also as a pre-req for better test coverage in project lilypad.

A few changes have been made to the UI test for it to work after the UI changes:

  1. Re-ordered add customer note as the first action - there were issues with scrolling on the test, and since we're testing the ability to create notes, this re-order does not reduce test coverage
  2. Remove the following steps from the test: updateOrderStatus (since the test is creating a new order, this option isn't visible on screen) and addShipping (has been replaced by the custom amount field on this particular test because of the mock file used)
  3. Created a new helper method, waitForElementToBeEnabled to better test conditions when the button is visible but not yet enabled

Testing instructions

Instrumented tests should be 🟢 in CI and should include previously skipped test e2eCreateOrderTest

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

@jostnes jostnes added the category: ui tests Related to UI testing. label Feb 1, 2024
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Feb 1, 2024

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
FlavorJalapeno
Build TypeDebug
Commitfbccac8
Direct Downloadwoocommerce-prototype-build-pr10660-fbccac8.apk

@jostnes jostnes marked this pull request as ready for review February 1, 2024 05:43
@jostnes jostnes requested a review from a team as a code owner February 1, 2024 05:43
@jostnes jostnes modified the milestones: 17.2, 17.3 Feb 1, 2024
Copy link
Contributor

@tiagomar tiagomar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on it, @jostnes !

The changes look good, the test pass locally multiple times, and CI is 🟢. :shipit:

@jostnes jostnes merged commit ed09ff1 into trunk Feb 6, 2024
18 of 21 checks passed
@jostnes jostnes deleted the test/fix-create-order-ui-test branch February 6, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: ui tests Related to UI testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants