Fix wc-admin nav styles after GB 11.6.0 changes #7771
Conversation
| @@ -71,4 +71,40 @@ | |||
| padding: $gap $gap-smaller $gap-small $gap-smaller; | |||
| } | |||
| } | |||
|
|
|||
| /* | |||
| * Override Gutenberg changes to the navigation component introduced in 11.6.0 by https://github.com/WordPress/gutenberg/pull/34885 | |||
There was a problem hiding this comment.
Are the changes in Gutenberg temporary or permanent? If we don't see them going away anytime soon, we can probably remove this comment and merge these styles with the above .components-navigation__menu selector.
It's hard to tell from the discussion in WordPress/gutenberg#34885 but it seems like they want to move to the G2 navigation, but updated the styles in this nav component anyway. I have some doubts if the styling will be reverted back even if they migrate to g2.
There was a problem hiding this comment.
I don't know enough about these components to comment with any kind of authority but yea, I doubt these are temporary which is why I opted to keep them out of the "temporary" section above. Wrt merging in with the rest of the code I think its worth keeping overrides distinctly separate but maybe this whole section is overrides?
There was a problem hiding this comment.
Yes, this section is overriding GB components. I went ahead and merged these selectors/styles together. Thank you very much for the changes, @lsl!
Co-authored-by: Joshua T Flowers <[email protected]>
|
@mattsherman I'm not 100% sure, but I think @lsl made all the changes except merging these with existing selectors. I can do that today so we can get this merged and cherry picked. |
|
Hey @mattsherman - @lsl's other changes looked good. I merged with our existing selectors in 2bdbb5b and also fixed up a back button sizing issue I noticed in e882997. This could use some 👀 before cherry picking just to sanity check my additions. |
There was a problem hiding this comment.
I tested this with the problematic version of Gutenberg and previous versions. Either case is looking good and I didn't notice any style issues. Code changes look sane as well.
I saw some whitespace issues and fixed them in b7a2990 by just letting WP Prettier do its thing. I'm not sure how that escaped the pre-commit hooks which I thought handled this sort of thing 🤷🏽♀️
Many thanks @lsl for kicking this off and @joshuatf for following up 🥇
|
Merging this as it's reviewed sufficiently. Thanks again, folks! |
* Fix wc-admin nav styles after GB 11.6.0 changes * log * Update changelogs/fix-nav-style Co-authored-by: Joshua T Flowers <[email protected]> * Hover fix for back button * Merge styles with existing * Fix back button size * fix whitespace issues Co-authored-by: Joshua T Flowers <[email protected]> Co-authored-by: Paul Sealock <[email protected]>
…rce-admin#7771) * Fix wc-admin nav styles after GB 11.6.0 changes * log * Update changelogs/fix-nav-style Co-authored-by: Joshua T Flowers <[email protected]> * Hover fix for back button * Merge styles with existing * Fix back button size * fix whitespace issues Co-authored-by: Joshua T Flowers <[email protected]> Co-authored-by: Paul Sealock <[email protected]>
Fixes #7683
A recent GB refactor broke the styling in wc-admin, this PR introduces some of the same changes that were used in that PR.
Detailed test instructions:
Screenshots
Before 11.6.0
Before this change
After this change
