This repository has been archived by the owner on Jul 12, 2024. It is now read-only.
Download Report API: Add path to response, fix ordering, and fix schema typo #1248
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1245.
This PR fixes a few issues with the download report endpoints.
download_path
to the response which contains a URL to the download of the file.download_count
anddownloads_count
in the schema.Note on
download_path
:This links to the file path that is stored in the product data. This can link externally or to the media library. It is different from a WC download link. Download links are tied to orders/users, so to use that we would need to generate permissions for each admin and link here otherwise.
Detailed test instructions:
phpunit
should be enough to test the changes here, though you can make manual requests or test the report page as well.