Setup for CocoaPods and SPM distribution #5
Conversation
| #### Development Builds | ||
| ```ruby | ||
| # Reference a commit hash | ||
| pod 'WooCommerceShared', git: 'https://github.com/woocommerce/WooCommerce-Shared.git', commit: '6cba1e9' | ||
|
|
||
| # Reference a branch | ||
| pod 'WooCommerceShared', git: 'https://github.com/woocommerce/WooCommerce-Shared.git', branch: 'trunk' |
There was a problem hiding this comment.
Because this CocoaPod uses pre-built binaries, referencing a commit or a branch might not result in the binary that's downloaded reflecting the state of the source code.
| echo "--- :amazon-s3: Uploading" | ||
| GIT_HASH=$(git rev-parse --short HEAD) | ||
| aws s3 cp dist/WooCommerceShared.xcframework.zip s3://a8c-apps-public-artifacts/woocommerce-shared/${GIT_HASH}/WooCommerceShared.xcframework.zip |
There was a problem hiding this comment.
I started building an upload_to_s3 command in the CI toolkit, but I half regret it now... There's really little difference than calling aws directly
There was a problem hiding this comment.
@jkmassel I run into various issue recently while working on the Gutenberg XCFramework with CocoaPods, and it looks like this setup is experiencing similar problems as the podspec doesn't pass validation:
Unfortunately, I haven't been able to get my Gutenberg setup to work yet. I am working around it by downloading and unpacking the archive and using a local podspec that refers to the files on my system. See wordpress-mobile/WordPress-iOS#20717
Add RuboCop configuration file and address violations
jkmassel
force-pushed
the
add/readme
branch
11 times, most recently
from
0bff291 to
cd13050
Compare
|
Ok, so weirdly enough 42fbf15 works, but it's...kinda gross. For some reason the I'm not sure what I'm missing – I know the I think this approach proves the concept, but I might have to dig into CocoaPods internals to figure out the |
That's the same conclusion I got to 😞 I started looking into |
|
@Ecarrion – sorry about the wait – this is ready. CocoaPods is still a bit of a mess (we can make it build fine if we reference the Git repo, but we can't push to a public Pod until we figure out why it doesn't properly support Fortunately, WCiOS seems to already heavily use SwiftPM, and that works fine. The release process is a little weird, but I've added it to Please try adding this repo to the project using SwiftPM, and choose the /cc @shiki |
Adds instructions on how to use the library, as well as the Podspec and Package.swift that make it work.
Doesn't yet publish the package to CocoaPods.
SwiftPM only allows packages to be distributed as ZIP files, so this PR adjusts that.