Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw a helpful error message when returning an empty list in pageListBuilder #68

Merged
merged 1 commit into from
Oct 8, 2023
Merged

Throw a helpful error message when returning an empty list in pageListBuilder #68

merged 1 commit into from
Oct 8, 2023

Conversation

TahaTesser
Copy link
Collaborator

@TahaTesser TahaTesser requested a review from ulusoyca October 7, 2023 17:01
ulusoyca
ulusoyca approved these changes Oct 8, 2023
View reviewed changes
Copy link
Collaborator

@ulusoyca ulusoyca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We need more tests. Hopefully, as the package evolves, will increase the coverage

@ulusoyca ulusoyca merged commit 35e451d into woltapp:main Oct 8, 2023
@TahaTesser TahaTesser deleted the pageListBuilder_error_message branch October 8, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulusoyca ulusoyca ulusoyca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Throw a helpful error when returning an empty list in pageListBuilder
2 participants
@TahaTesser @ulusoyca