Remove extra scrollbars in the modal sheet due to nested scroll views #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulusoyca
force-pushed
the
issue-46-remove-extra-scrollbar-due-to-nested-scroll-views
branch
from
3f39514 to
37c2325
Compare
ulusoyca
commented
Sep 9, 2023
| top: 0, | ||
| child: WoltBottomSheetDragHandle(), | ||
| ), | ||
| return Stack( |
There was a problem hiding this comment.
Only change here is removing the parent.
ulusoyca
force-pushed
the
issue-46-remove-extra-scrollbar-due-to-nested-scroll-views
branch
from
37c2325 to
ce8316a
Compare
|
I remember making a similar change in one of the Flutter samples |
|
@TahaTesser Thanks for the review! Any idea about this exception? which is throwing needs layout exception when scrolling with drag gestures on desktop apps |
ulusoyca
deleted the
issue-46-remove-extra-scrollbar-due-to-nested-scroll-views
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Issue reported within #46
This PR addresses an issue where an extra scrollbar was being displayed in web and desktop apps when a nested scroll view was present within a modal page constructed with
withSingleChildfactory method.Changes Made:
Wrapped the singleChildContent within a ScrollConfiguration widget the copy of the parent scroll behavior and changed the scrollbars to false for the descendants.
before.mov
after.mov