[Breaking Change] Introduce modal and page content decorators #267
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the modal decoration mechanism to separate the decoration of the modal barrier + content from the decoration of the content only. This also aligns it with the WoltModalType class methods, and resolves the existing issue with the decorator context (see comment).
Methods in
WoltModalType
class:decoratePageContent
anddecorateModal
:This PR introduces
pageContentDecorator
andmodalDecorator
:Changes Made to Decorator Functions
Removed:
Added:
Benefits
The decorator function is split into
pageContentDecorator
andmodalDecorator
. This fixes the issue stated by @vishna in this comment. Previously, the decorator function only decorated the page modal content, leading to errors when the pageListBuilder created the pages because the decorator context was built after the pages are built.Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
).This will ensure a smooth and quick review process.
///
).melos run analyze
) does not report any problems on my PR.