Fix: Dialog and bottom sheet minimum height is not respected to modal content min height #260
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dialog and bottom sheet min height is not respected to modal constraints. We added this test case to playground app.
The root cause is that the modal content constraints are calculated without consideration of the available space and it is independent of the modal constraints. When the min height is more than the content height, we currently don't fill the space to min height. It could be added as a feature in later updates, but adding this feature now will complicate the internal implementation. We can address this issue when we use the page as widget.
page_with_min_height_before.mov
page_with_min_height_after.mov
Related Issues
Issue #259
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
).This will ensure a smooth and quick review process.
///
).melos run analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?