Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert MaterialApp example app to CupertinoApp #120

Merged

Conversation

yunusemrebakir
Copy link
Collaborator

@yunusemrebakir yunusemrebakir commented Jan 10, 2024

Description

Our all example apps are uses MaterialApp at the top level, we are switching to CupertinoApp in coffee_maker example to also demonstrate that.

Before After
before.mp4
after.mp4

Related Issues

#61

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes tests for all changed/updated/fixed behaviors.
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • The package compiles with the minimum Flutter version stated in the pubspec.yaml

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@yunusemrebakir yunusemrebakir marked this pull request as ready for review January 10, 2024 15:05
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@yunusemrebakir yunusemrebakir enabled auto-merge (squash) January 10, 2024 15:45
@yunusemrebakir yunusemrebakir merged commit 1fffcfd into woltapp:main Jan 10, 2024
2 checks passed
@yunusemrebakir yunusemrebakir deleted the coffee-maker-cupertino-app branch January 11, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants