[Issue-96] Fix TopBar Widget keeps being visible after Keyboard hides #119
Conversation
check only min extent Repaint after keyboard closing
ulusoyca
force-pushed
the
fix-top-bar-visibility-when-keyboard-disappears
branch
from
69069ed to
e6a906a
Compare
| ) async { | ||
| if (!visible) { | ||
| /// Wait for closing soft keyboard animation to finish before emitting new value. | ||
| await Future.delayed(const Duration(milliseconds: 250)); |
There was a problem hiding this comment.
Is it possible that different devices will have different keyboard open/close duration which might affect this? I wonder is it possible to read information this from system/device
There was a problem hiding this comment.
i've the same concern. This needs to be more testing to be sure.
There was a problem hiding this comment.
@TahaTesser how is this problem approached in Flutter in general? I will have a second look to address this.
There was a problem hiding this comment.
Framework gets native callbacks for events that happen on the system level.
I spent significant time to resolve this issue without a package but it was really difficult. Thanks for reviewing! |
Description
This PR fixes the top bar widget visibility issue due to keyboard closing event (#96) by introducing a new feature in the form of a value notifier, specifically designed to detect the dismissal of the soft-keyboard. This PR primarily impacts two components:
WoltModalSheetTopBarFlowandWoltModalSheetTopBarTitleFlow.Key points
Purpose
The primary goal of this implementation is to trigger a re-paint in the top bar components when the soft-keyboard is closed. This is essential to prevent the top bar from being stuck unresponsive after the keyboard's closing phase.
Default Behavior Sync with Scroll Controller
When
isTopBarAlwaysVisibleis set to false (by default), the visibility and appearance of the top bar and top bar title are synchronized with the scroll controller's position. BothWoltModalSheetTopBarFlowandWoltModalSheetTopBarTitleFlowuse the scroll position data to determine how the top bar should be painted.Challenge with Keyboard Events
While the appearance of the soft-keyboard naturally triggers scroll update events (courtesy of the Flutter SDK), its dismissal does not inherently cause a similar update in the scroll controller. This discrepancy leads to a situation where the top bar does not repaint as expected when the keyboard closes.
Solution
To address this, the implemented value notifier actively detects the dismissal of the keyboard. Upon this event, it manually triggers a repaint for the top bar flow and top bar title flow widgets. This ensures that the top bar refreshes its state appropriately, maintaining a smooth and responsive user interface.
Additional Changes
NotificationControllerwidget inside theWoltModalSheetMainContentis removed since the scroll position is listened directly from the scroll controllers insideWoltModalSheetAnimatedSwitcherwidget.BuildContextto flow delegates is removed.Screenshots
fix_before_scroll_position.mp4
fix_after_scroll.mp4
Related Issues
#96
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process.
///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
6.0.0.