Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added final activation before eval score calculation #101

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

jens-maus
Copy link
Contributor

This PR applies the same final activation function before calculating the eval score than before calculating the validation score accordingly. This should make eval score calculation consistent with the validation score calculation (e.g. in case the Dice coefficient is used) so that both metrics are more comparable to each other.

@wolny
Copy link
Owner

wolny commented Dec 4, 2023

Hi @jens-maus, that's a really nice catch! Currently the final_activation is only applied when the model is in the validation mode (see: https://github.com/wolny/pytorch-3dunet/blob/master/pytorch3dunet/unet3d/model.py#L97). This PR correctly applies the final_activation when we want to compute the evaluation metric in the training mode. Thanks!

@wolny wolny merged commit b70a54e into wolny:master Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants