Support custom headers in aws_sigv4_url/1 #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjreinhart
commented
Jan 2, 2025
| {"X-Amz-Expires", expires}, | ||
| {"X-Amz-SignedHeaders", signed_headers} | ||
| ], | ||
| # Ensure spaces are encoded as %20 not + |
There was a problem hiding this comment.
While this should not be a problem with the existing implementation (because arbitrary query params are not supported), this felt like a potential bug waiting to happen, so I updated to use the correct whitespace encoding.
|
Thank you! |
This was referenced Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
S3-compatible APIs support additional headers for certain behaviors. For example, my team wants to create presigned urls for uploading files from the client. To ensure integrity of uploads and keep track of storage consumption by our end users, we want to enforce the uploaded file is the size reported by the client. This can be accomplished using the
content-lengthheader.S3 supports
content-length-rangewhich I see is used by req_s3presign_form/1. However, we're using Cloudflare R2 via their S3-compatible API and it appears that value is not supported but thecontent-lengthheader is. Additionally, we want the exact size to be enforced, not a range or max.This PR supports arbitrary headers passed to
Req.Utils.aws_sigv4_url/1. I wasn't entirely sure where this belongs as there is S3-signing-related logic in a few places (this module and req_s3). From what I could tell, signature logic should be added here. Happy to adjust if needed.