Add required duplex option to RequestInit #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see also nodejs/node#46221 and microsoft/TypeScript-DOM-lib-generator#1483
This will prevent the following runtime error:
This is the fix as suggested by @KararTY in Issue #4
I can confirm vitest passes, the typecheck does fail, but for the known reason that microsoft/TypeScript-DOM-lib-generator#1483 mentions regarding the incomplete type in their spec which has fallen behind the actual node implementation.
With the single line added for duplex: 'half', the build in dist works without errors when imported into an Express app and used as middleware.
(PR previously submitted as #6)