Fixes bug with attachment encoding #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, the encoding/base64 in Go does not add line breaks to its output. This patch introduces the Base64LineBreaker which satisfies the io.WriteCloser interface Attachments are now correctly broken up into maximum of 76 chars
Codecov Report
@@ Coverage Diff @@
## main #38 +/- ##
==========================================
- Coverage 82.99% 82.43% -0.57%
==========================================
Files 10 11 +1
Lines 1094 1127 +33
==========================================
+ Hits 908 929 +21
- Misses 131 139 +8
- Partials 55 59 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully addresses #37 too.
By default, the encoding/base64 in Go does not add line breaks to its output. This patch introduces the Base64LineBreaker which satisfies the io.WriteCloser interface. Attachments are now correctly broken up into maximum of 76 chars. This hopefully satisfies the requirements of more strict mail servers, that do not allow lines longer than 78 chars (SHOULD)/998 chars(MUST) - see: https://www.rfc-editor.org/rfc/rfc5322#section-2.1.1