2.11.0 #221

wmonk · 2018-01-11T09:01:39Z

This is the merged upstream of facebook 1.0.17

* Print file sizes with correct build folder path. * Just use the print the basename.

Simplified steps for deploying app to `now` as a static site. No need to `serve` script in `package.json` file. As of May 15, 2017, all static deployments on `now` are free and unlimited.

…ncluded the fixed for Uglify bug (#2351)

* Disable a micro-option in uglify that appears to be buggy See facebook/create-react-app#2376 * wrong plugin * Add a comment

- [email protected] - [email protected] - [email protected]

* Update e2e-kitchensink.sh * Try again (differently)

* Revert "Fix wrong path expansion in end-to-end test (#2388)" This reverts commit 2aafaad. * Revert "Suggest just "yarn build" (#2385)" This reverts commit 70bf125. * Revert "Catch "No tests found" during CI (#2387)" This reverts commit 5317b3f.

* Added cache clear to e2e scripts * Install latest yarn on AppVeyor to avoid windows crashing bug in yarn * Alternative fix for yarn crashing e2e tests on windows machines

* Fix detection of parent directory * Correct parent directory detection fix Add windows specific path and extend to issuer path

since CRA now use the latest version of Jest under the hood, `jest-enzyme` v3.2.0 is now working perfectly fine

"ensuring that you web app" -> "ensuring that your web app"

Removed Node v4 (CRA only supports Node >= 6)

* re-add storybook && update the documentation and links * Change to new documentation domain

* Added NamedModulesPlugin in webpack.config.dev.js * Update webpack.config.dev.js

Resolves #2481

* Update README.md to make links to webpack point to webpack.js.org instead insteade of webpack 1 webpack.githup.io

- Call `npm run flow --init` won't create a .flowconfig file, it should be `npm run flow init`

This eliminates a `yarn` warning on OSX machines running Node.js 8. See here for details: fsevents/fsevents#170 You can see an example of the warning in the second screenshot in facebook/create-react-app#2422 (comment)

* Update README.md Fix broken link to React Router documentation * Update README.md

- [email protected] - [email protected] - [email protected]

Fixed a small grammatical issue that I noticed while browsing the README today

* Add link to VS Code troubleshooting guide * Update README.md

"subway" by itself is not a proper noun

- [email protected]

DorianGrey

Just found two minor changes to be (re-)applied.

DorianGrey · 2018-01-12T07:14:28Z

packages/react-dev-utils/WebpackDevServerUtils.js

@@ -187,7 +183,7 @@ function createCompiler(webpack, config, appName, urls, useYarn) {
      );
      console.log(
        'To ignore, add ' +
-          chalk.cyan('// tslint:disable-next-line') +
+          chalk.cyan('// eslint-disable-next-line') +


This should remain tslint:disable-next-line - we're not using ESLint.

I think this is an unneeded change isn't it, as we still use the published react-dev-utils not a ts specific one?

Oh - yeah, my bad.

DorianGrey · 2018-01-12T07:27:37Z

packages/react-scripts/scripts/utils/createJestConfig.js

    },
-    transformIgnorePatterns: [
-      '[/\\\\]node_modules[/\\\\].+\\.(js|jsx|ts|tsx)$',
-    ],


Suppose this pattern should not be removed, but only extended to also cover mjs:

transformIgnorePatterns: [ '[/\\\\]node_modules[/\\\\].+\\.(js|jsx|mjs|ts|tsx)$' ]

DorianGrey · 2018-01-13T12:32:30Z

packages/react-scripts/scripts/utils/createJestConfig.js

+      '^.+\\.css$': resolve('config/jest/cssTransform.js'),
+      '^(?!.*\\.(js|jsx|mjs|css|json)$)': resolve(
+        'config/jest/fileTransform.js'
+      ),
    },
    transformIgnorePatterns: [
      '[/\\\\]node_modules[/\\\\].+\\.(js|jsx|ts|tsx)$',


As mentioned in the last comment, the pattern should include mjs:

'[/\\\\]node_modules[/\\\\].+\\.(js|jsx|mjs|ts|tsx)$'

This pattern was extended to include mjs a couple of months ago already.

fezhengjin and others added 30 commits May 25, 2017 16:18

Print file sizes with correct build folder path. (#2361)

b60f55c

* Print file sizes with correct build folder path. * Just use the print the basename.

Update README.md for now deployments (#2372)

fbaeff2

Simplified steps for deploying app to `now` as a static site. No need to `serve` script in `package.json` file. As of May 15, 2017, all static deployments on `now` are free and unlimited.

Removed the overriding of reduce_vars to false since webpack v2.6.0 i…

c1ba38d

…ncluded the fixed for Uglify bug (#2351)

Disable comparisons feature in uglify compression in production (#2379)

f6d8544

* Disable a micro-option in uglify that appears to be buggy See facebook/create-react-app#2376 * wrong plugin * Add a comment

Consistently set environment variables (#2382)

2069e8a

Update webpack to 2.6.1 (#2383)

1421010

Add changelog for 1.0.7 (#2384)

84efd45

Publish

58d8c5c

- [email protected] - [email protected] - [email protected]

Catch "No tests found" during CI (#2387)

5317b3f

Suggest just "yarn build" (#2385)

70bf125

Fix wrong path expansion in end-to-end test (#2388)

2aafaad

* Update e2e-kitchensink.sh * Try again (differently)

Fix kill command in e2e-kitchensink.sh cleanup (#2397)

e6ddfb0

Added cache clear to e2e scripts (#2400)

32f82c0

* Added cache clear to e2e scripts * Install latest yarn on AppVeyor to avoid windows crashing bug in yarn * Alternative fix for yarn crashing e2e tests on windows machines

Fix detection of parent directory in ModuleScopePlugin (#2405)

bcf398d

* Fix detection of parent directory * Correct parent directory detection fix Add windows specific path and extend to issuer path

docs: update jest-enzyme section (#2392)

19c5277

since CRA now use the latest version of Jest under the hood, `jest-enzyme` v3.2.0 is now working perfectly fine

Add WebStorm >2017 launchEditor Support (#2414)

02f88ba

Fix docs typo (#2420)

e91648a

"ensuring that you web app" -> "ensuring that your web app"

Update Travis CI Node versions in User Guide (#2454)

d1f37d9

Removed Node v4 (CRA only supports Node >= 6)

re-add storybook && update the documentation and links (#2331)

e898215

* re-add storybook && update the documentation and links * Change to new documentation domain

Prioritize index.css over the implicit App.css (#2470)

b264b8d

Added NamedModulesPlugin in webpack.config.dev.js (#2458)

c78c1fa

* Added NamedModulesPlugin in webpack.config.dev.js * Update webpack.config.dev.js

Unscope detect-port (#2483)

dc4ce60

Resolves #2481

Update webpack links to point to webpack 2 (#2492)

9438c5b

* Update README.md to make links to webpack point to webpack.js.org instead insteade of webpack 1 webpack.githup.io

chore(templates): Move GitHub templates to hidden .github folder (#2489)

054778f

Fix minor docs typo (#2500)

cccd855

Fix link to Storybook docs (#2521)

9b3cf2f

Simplify flow init docs (#2522)

67f6163

- Call `npm run flow --init` won't create a .flowconfig file, it should be `npm run flow init`

Upgrade fsevents to 1.1.2 (#2550)

acb1957

This eliminates a `yarn` warning on OSX machines running Node.js 8. See here for details: fsevents/fsevents#170 You can see an example of the warning in the second screenshot in facebook/create-react-app#2422 (comment)

Fix broken link to React Router docs (#2538)

e6f9935

* Update README.md Fix broken link to React Router documentation * Update README.md

piotr-cz and others added 12 commits October 31, 2017 10:25

Update favicon description (#3374)

1740c3f

Changelog for 1.0.16 (#3376)

7ae6ab1

Reorder publishing instructions

b8e6ba3

Publish

dc95d18

- [email protected] - [email protected] - [email protected]

Update README.md (#3392)

74c523c

Fixed a small grammatical issue that I noticed while browsing the README today

Update VS Code debug configuration (#3400)

35fa70e

Add link to VS Code troubleshooting guide (#3399)

2cb4871

* Add link to VS Code troubleshooting guide * Update README.md

Fix grammar in README (#3394)

90c83f7

"subway" by itself is not a proper noun

Use new WebpackDevServer option (#3401)

5811d55

Add 1.0.17 changelog (#3402)

cfbd468

Publish

4b55193

- [email protected]

Merge facebookincubator/[email protected]

1061fde

wmonk mentioned this pull request Jan 11, 2018

2.9.0 #220

Merged

wmonk requested a review from DorianGrey January 11, 2018 09:03

wmonk added 6 commits January 11, 2018 09:14

Fix Missing Variable

237c0fa

Fix

6f0c62f

Update JestConfig Creation

bb74fb6

Readd Missing raf Package

16af26f

Update package.json dependencies

0d43626

Update react-dev-utils

b072857

DorianGrey suggested changes Jan 12, 2018

View reviewed changes

Readd transformIgnorePatterns

13c0e7f

wmonk changed the base branch from 2.9.0 to master January 13, 2018 10:01

wmonk changed the title ~~2.10.0~~ 2.11.0 Jan 13, 2018

DorianGrey suggested changes Jan 13, 2018

View reviewed changes

Update createJestConfig.js

e637c79

DorianGrey approved these changes Jan 13, 2018

View reviewed changes

wmonk mentioned this pull request Jan 14, 2018

Upgrade to TypeScript 2.6.1 #191

Closed

wmonk merged commit ea32709 into master Jan 14, 2018

wmonk deleted the 2.10.0 branch January 14, 2018 17:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

2.11.0 #221

2.11.0 #221

wmonk commented Jan 11, 2018 •

edited

Loading

DorianGrey left a comment

DorianGrey Jan 12, 2018

wmonk Jan 12, 2018

DorianGrey Jan 13, 2018 •

edited

Loading

DorianGrey Jan 12, 2018

DorianGrey Jan 13, 2018

wmonk Jan 13, 2018

2.11.0 #221

2.11.0 #221

Conversation

wmonk commented Jan 11, 2018 • edited Loading

DorianGrey left a comment

Choose a reason for hiding this comment

DorianGrey Jan 12, 2018

Choose a reason for hiding this comment

wmonk Jan 12, 2018

Choose a reason for hiding this comment

DorianGrey Jan 13, 2018 • edited Loading

Choose a reason for hiding this comment

DorianGrey Jan 12, 2018

Choose a reason for hiding this comment

DorianGrey Jan 13, 2018

Choose a reason for hiding this comment

wmonk Jan 13, 2018

Choose a reason for hiding this comment

wmonk commented Jan 11, 2018 •

edited

Loading

DorianGrey Jan 13, 2018 •

edited

Loading