Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split main CI into tests and docs #399

Merged
merged 12 commits into from
Feb 15, 2023
Merged

split main CI into tests and docs #399

merged 12 commits into from
Feb 15, 2023

Conversation

tomkralidis
Copy link
Collaborator

Addresses #397

@tomkralidis tomkralidis added the documentation Improvements or additions to documentation label Feb 15, 2023
@tomkralidis tomkralidis added this to the sprint-009 milestone Feb 15, 2023
@tomkralidis tomkralidis changed the title [WIP] split main CI into tests and docs split main CI into tests and docs Feb 15, 2023
@maaikelimper
Copy link
Collaborator

I think we can reduce requirements-dev.txt for 'test docker deployment' to:
flake8
requests
pytest

If I understand correctly requirements-dev.txt contains the python-dependencies to run the integration test for the wis2box-stack, perhaps I could be located outside of the wis2box-managment-folder ?

The python requirements for docs could be managed in a separate requirements-doc.txt

Copy link
Member

@webb-ben webb-ben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Purpose of building docs in test workflow was because they were failing on commits to main. Why are the docs/ path commented out?

@tomkralidis
Copy link
Collaborator Author

The docs/ paths were commented so as to trigger docs CI in this PR. I've commented them out now that we have an approval.

@tomkralidis tomkralidis merged commit fc423e7 into main Feb 15, 2023
@tomkralidis tomkralidis deleted the issue-397 branch February 15, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants