pass BODY_WIDTH as 3rd argument to html2text() #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setting BODY_WIDTH in config.py alone doesn't work anymore since html2text has gone through some refactoring and probably broke backwards compability. now we need to pass BODY_WIDTH as 3rd argument to the html2text initializer. i think these are the html2text commits that let to this incompability: Alir3z4/html2text@1ba191f Alir3z4/html2text@192ca94 without this fix, changing body-width (to 0 for example) in rss2email.cfg has no effect.
|
Hi, Note that until Alir3z4/html2text#84 this kwarg was ignored. Now that it's fixed, setting the configuration should work. But now that html2text is more powerful and can be configured without globals, this PR might be the occasion to modify the way it is configured in rss2email. Namely, removing What do you think? |
|
Hey, that's great, thanks for your work! I guess this hotfix is obsolete then. Definitely a good idea to refactor the setup code and clean this up, let's keep that in mind for a separate pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setting BODY_WIDTH in config.py alone doesn't work anymore since
html2text has gone through some refactoring and probably broke backwards
compability.
now we need to pass BODY_WIDTH as 3rd argument to the html2text
initializer.
i think these are the html2text commits that let to this incompability:
Alir3z4/html2text@1ba191f
Alir3z4/html2text@192ca94
without this fix, changing body-width (to 0 for example) in
rss2email.cfg has no effect.
Signed-off-by: Sebastian Volland [email protected]