gui: use descriptor helper function to get unsigned tx max size #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll leave this as draft until #881 has been merged. |
darosior
reviewed
Dec 15, 2023
gui/src/daemon/model.rs
Outdated
| self.fee_amount.map(|a| { | ||
| a.to_sat() | ||
| .checked_div(self.max_vbytes) | ||
| .expect("max_vbytes should be greater than zero") |
There was a problem hiding this comment.
nit: Hopefully, yes! But why? I think that's the info which should go here. For instance "a PSBT with an empty unsigned_tx would never deserialize therefore this is never 0" or simply "a descriptor's satisfaction size is never 0".
There was a problem hiding this comment.
I've now changed this to the second suggestion.
jp1ac4
force-pushed
the
gui-use-helper-unsigned-tx-max-size
branch
from
49ec4f5 to
bf52982
Compare
jp1ac4
force-pushed
the
gui-use-helper-unsigned-tx-max-size
branch
from
bf52982 to
e373ad4
Compare
|
The GUI is now pointing to the latest master. |
|
ACK e373ad4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to resolve #880 using the new helper function from #881 to get the max possible size of the unsigned transaction.
The following screenshot is taken using both new and old implementations together and shows the new estimated feerate changes from 0 to 1 sat/vbyte:
