Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bitbox unsupported status when no wallet yet #879

Merged

Conversation

edouardparis
Copy link
Member

During the install process, no wallet yet is created and bitbox should not be marked as unsupported if
its fingerprint is not in any descriptor.

During the install process, no wallet yet is created
and bitbox should not be marked as unsupported if
its fingerprint is not in any descriptor.
Copy link
Member Author

@edouardparis edouardparis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-ACK 1fa414b

@edouardparis edouardparis merged commit 683a500 into wizardsardine:master Dec 14, 2023
18 checks passed
@edouardparis edouardparis deleted the fix-master-unsupported-bitbox branch December 14, 2023 13:11
edouardparis added a commit that referenced this pull request Dec 15, 2023
…let yet

ed19a98 fix bitbox unsupported status when no wallet yet (edouardparis)

Pull request description:

  During the install process, no wallet yet is created and bitbox should not be marked as unsupported if
  its fingerprint is not in any descriptor.

ACKs for top commit:
  edouardparis:
    Self-ACK ed19a98

Tree-SHA512: 6917c5aaeaa6a9d3ae8c890374fc23c543fbbd385d418ab0824273c5b022207f4a2db4d22b4d0c7207117d6e05a56af2bd6cf197fb7b8be68c0a859c9be22c99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant