Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copy paste overlay buttons to text_input #1570

Merged

Conversation

edouardparis
Copy link
Member

We add an overlay to the fork of the text_input widget to display "Paste" when user clicks on Right click.
When a text is selected, the button Copy is added to the overlay choices.
20250211_14h38m41s_grim
20250211_14h39m04s_grim

@edouardparis edouardparis force-pushed the fork-text_input-widget branch from e5187ef to 682331a Compare February 11, 2025 13:56
@jp1ac4
Copy link
Collaborator

jp1ac4 commented Feb 11, 2025

From a quick test of 682331a:

The position of the Paste button can be off, e.g. when there's already text in the box:
image

Also, the paste button colour seems to remain green after it's been hovered over previously, even if it's not currently selected (left-click won't do anything):
image

@nondiremanuel nondiremanuel added GUI gui related Enhancement Improving an existing functionality Nice to have If it's not completed in time for the current version, it can be postponed labels Feb 12, 2025
@edouardparis edouardparis force-pushed the fork-text_input-widget branch from 682331a to 74f10a5 Compare February 12, 2025 15:22
Copy link
Collaborator

@jp1ac4 jp1ac4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 74f10a5.

It's working nicely from my tests.

@edouardparis edouardparis merged commit 22c2a23 into wizardsardine:master Feb 12, 2025
11 of 12 checks passed
@edouardparis edouardparis deleted the fork-text_input-widget branch February 12, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improving an existing functionality GUI gui related Nice to have If it's not completed in time for the current version, it can be postponed
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants