Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GUI: Show blockchain sync progress as percentage to 2 decimal places #907

Closed
jp1ac4 opened this issue Jan 4, 2024 · 7 comments
Closed

GUI: Show blockchain sync progress as percentage to 2 decimal places #907

jp1ac4 opened this issue Jan 4, 2024 · 7 comments
Labels
Good first issue Good for newcomers
Milestone
v9 Liana - UI fix...

Comments

@jp1ac4
Copy link
Collaborator

jp1ac4 commented Jan 4, 2024

Currently, the percentage is shown to 2 decimal places, but the second decimal is always 0:

image

I think this can be resolved by increasing the number of decimal places of the "sync" entry in Liana's getinfo command to 4.
@kloaec
Copy link
Collaborator

kloaec commented Jan 10, 2024

@darosior can you tag this one "good first issue"? It should be a super easy one :)

@pythcoiner pythcoiner added the Good first issue Good for newcomers label Jan 10, 2024
@AnmolSirola
Copy link

@jp1ac4 Can I take this one ?

@jp1ac4
Copy link
Collaborator Author

jp1ac4 commented Jan 19, 2024

Sure, that would be great thanks. Please note that it might not be possible to update the GUI's liana dependency yet as its rust-bitcoin dependency needs to be updated to v0.31 still, but it should be enough for this issue to update the "sync" entry as mentioned above and then the GUI's liana dependency will be updated elsewhere.

@AnmolSirola AnmolSirola mentioned this issue Feb 2, 2024
Closed
@thomask7b thomask7b mentioned this issue Nov 12, 2024
Merged
edouardparis added a commit that referenced this issue Nov 13, 2024
@edouardparis
Merge #1457: Fix blockchain sync progress
b46efc6 
439af75 Fix blockchain sync precision, add tests (thomas)

Pull request description:

  I've merged `roundup_progress` in `rounded_up_progress` since was in utils and was no longer used by any other method.
  I also added some tests to verify the precision's update but also for specific cases that we manage. By the way tests has been moved in the related file.

  Solves #907

ACKs for top commit:
  pythcoiner:
    ACK 439af75
  jp1ac4:
    Tested ACK 439af75.

Tree-SHA512: a87998d1e25c47d751dabc38f641f05f2544bf17cbdcf95d24e829a0aa9dd8ce2de3bdc72a52aced04ffd777412ca206641f914d9a083241d98ceea33d4c10cc
@jp1ac4
Copy link
Collaborator Author

jp1ac4 commented Nov 13, 2024

@nondiremanuel In #1386, the sync progress is shown on the home screen to 1 decimal place. Following #1457, we can now show it to 2 decimal places. Shall we use 2 decimal places on both the loading screen (for IBD) and home page (for existing wallets)?

@edouardparis
Copy link
Member

We need to update liana-gui with liana master then

@pythcoiner
Copy link
Collaborator

We need to update liana-gui with liana master then

@thomask7b can you do this?

@nondiremanuel
Copy link
Collaborator

@nondiremanuel In #1386, the sync progress is shown on the home screen to 1 decimal place. Following #1457, we can now show it to 2 decimal places. Shall we use 2 decimal places on both the loading screen (for IBD) and home page (for existing wallets)?

If it's not too complicated, I agree to align the behavior. Not a major priority though.

This was referenced Nov 13, 2024
Closed
Merged
edouardparis added a commit that referenced this issue Nov 18, 2024
@edouardparis
Merge #1465: Use 2 decimal for sync progression in home page
8e18313 
5d65a4e Use 2 decimal for sync progression in home page (thomas)

Pull request description:

  Solves #907

ACKs for top commit:
  pythcoiner:
    ACK [5d65a4e](5d65a4e)

Tree-SHA512: 677a132d42f426a37e30829e8a91bc6e7f258d3cfe808d4f0b5cadd1951b3cccd75527574200cf5e2319cf90e6ff5e6e88f387c457123cb9d556c81da458fe12
@nondiremanuel nondiremanuel moved this to Done in Liana General Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good first issue Good for newcomers
Projects
Liana General
Status: Done
Milestone
v9 Liana - UI fixes and other
Development

No branches or pull requests
6 participants
@edouardparis @kloaec @nondiremanuel @AnmolSirola @jp1ac4 @pythcoiner