ARM64 support in core toolset and extensions. #503
Conversation
| <BuildARM Condition=" '$(BuildARM)'!='true' ">false</BuildARM> | ||
| <BuildARM64 Condition=" Exists('$(PlatformSdkArmLibraryRoot)') ">true</BuildARM64> | ||
| <BuildARM64 Condition=" '$(BuildARM64)'!='true' ">false</BuildARM64> |
There was a problem hiding this comment.
I didn't see anything using this as a condition to skip building, did I miss something?
There was a problem hiding this comment.
Nope. Probably should have a couple of those...
There was a problem hiding this comment.
Ugh. Detection sucks. We need ARM64 in both the Windows SDK (included by default) and VS2017. We'd need VSWhere to determine if the ARM64 tools and libs are installed. We could also require a property to opt-in to the build, so you're not surprised when it fails on ARM/ARM64. @robmen, @rseanhall, opinions?
There was a problem hiding this comment.
I think requiring a property to opt-in is perfectly fine.
There was a problem hiding this comment.
I'm good with opt-in property as long as the OFFICIAL_BUILD fails if the opt-in property is not set. That way we don't forget to set in in the official build (because I undoubtedly will).
Set BuildARM=true and BuildARM64=true
No description provided.