Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refcator color props type to colorValue #3238

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

adids1221
Copy link
Contributor

@adids1221 adids1221 commented Sep 2, 2024

Description

Changed color props type from string to react-native - ColorValue type.
The ColorValue support OpaqueColorValue which support platform colors and dynamic colors.
Currently with string type we don't have support for that, this was request in the community open issues.
Example to reproduce type error:

 const dynamicColor: ColorValue = PlatformColor('systemBlue');
 <Button marginV-20 label="Button" backgroundColor={dynamicColor}/>

Changelog

Components colors props type change from string to ColorValue.

Additional info

#3202

@Inbal-Tish Inbal-Tish changed the title refcator color props type refcator color props type to colorValue Oct 21, 2024
@adids1221
Copy link
Contributor Author

TODO:
After installing snapshot version on the private repo I found few issues to fix

  • ColorPicker - value prop should be ColorValue
  • ColorPalette & ColorSwatch value props also should be ColorValue
  • Fix the TS errors for this components

Copy link

stale bot commented Jan 31, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant