Measure TopBar buttons using using MeasureSpec.UNSPECIFIED

This change lets buttons stretch horizontally using padding and margins and not only by changing width property explicitly.
wix · Dec 25, 2018 · dd93c51 · dd93c51
1 parent 43ae659
commit dd93c51
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/...d/app/src/main/java/com/reactnativenavigation/views/titlebar/TitleBarReactButtonView.java b/...d/app/src/main/java/com/reactnativenavigation/views/titlebar/TitleBarReactButtonView.java
@@ -15,9 +15,6 @@ public TitleBarReactButtonView(Context context, ReactInstanceManager reactInstan
 
     @Override
     protected void onMeasure(int widthMeasureSpec, int heightMeasureSpec) {
-        super.onMeasure(
-                getChildCount() > 0 ? MeasureSpec.makeMeasureSpec(getChildAt(0).getWidth(), MeasureSpec.EXACTLY) : widthMeasureSpec,
-                heightMeasureSpec
-        );
+        super.onMeasure(MeasureSpec.makeMeasureSpec(MeasureSpec.getSize(widthMeasureSpec), MeasureSpec.UNSPECIFIED), heightMeasureSpec);
     }
 }
diff --git a/playground/src/screens/CustomRoundedButton.js b/playground/src/screens/CustomRoundedButton.js
@@ -37,7 +37,7 @@ class CustomRoundedButton extends Component {
 
   render() {
     return (
-      <View style={styles.container} key={'guyguy'}>
+      <View style={styles.container}>
         <View style={styles.button}>
           <TouchableOpacity onPress={() => Alert.alert(this.props.title, 'Thanks for that :)')}>
             <Text style={styles.text}>{this.props.title}</Text>