fix(ios): streaming parsing for applesimutils --list #4335
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IIUC this is going to be agnostic to the user, because we await the cp anyways. So, not sure what to consider here, have I missed something? In addition, some extra thoughts here: Would it make sense to enable this on the util-level - namely, alongside (or bundled-in) In any case, a great improvement. |
|
@noomorph In this iteration, let's take a brave decision here to make to break. |
|
Closing in favor of the discussion in wix/AppleSimulatorUtils#122 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This solves an issue with very dirty iOS environments, where there are just way too many simulators.
As this solution is implemented via a streaming parser, we should no longer have issues with the magic
maxBuffernumber.