This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
Add a mysqladmin shutdown timeout & fixes to fallback shutdown logic. #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cess so it can execute fallback shutdown methods. Added mechanism to wait to see if the process actually stops after attempting fallback shutdown methods rather than assuming success.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added timeout to mysqladmin shutdown.
Set the process ID in MysqldProcess so it can execute the fallback shutdown methods (it was bypassing them previously because it didn't have this).
Added mechanism to wait to see if the process actually stops after attempting fallback shutdown methods rather than assuming success. Previously there would be cases where a 'kill' process would return 0, but the process either did not shutdown at all, or took some time to shut down after the process returns (which meant attempting to run a new server on the same port would fail). The new code waits (with a timeout) and checks to see the process disappear before reporting success to the caller.