Skip to content
This repository has been archived by the owner on Oct 11, 2022. It is now read-only.

Support hyperlinks in messages #4545

Merged
merged 2 commits into from
Jan 17, 2019
Merged

Support hyperlinks in messages #4545

merged 2 commits into from
Jan 17, 2019

Conversation

Chiamaka
Copy link
Contributor

Status

  • WIP
  • Ready for review
  • Needs testing

Deploy after merge (delete what needn't be deployed)

  • hyperion (frontend)

preview

@Chiamaka
Copy link
Contributor Author

Fix for #4541

@brianlovin brianlovin requested a review from mxstbr January 17, 2019 00:22
@brianlovin
Copy link
Contributor

!! This is awesome! Gonna have @mxstbr take a look :)

mxstbr
mxstbr approved these changes Jan 17, 2019
View reviewed changes
Copy link
Contributor

@mxstbr mxstbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow @Chiamaka I should have checked my notifications first, look at this: #4549!!!!

Thank you so much, this is a better than my implementation. Great job! 💯

@mxstbr mxstbr merged commit 2e6d742 into withspectrum:alpha Jan 17, 2019
@mxstbr mxstbr mentioned this pull request Jan 17, 2019
Closed
3 tasks
@Chiamaka
Copy link
Contributor Author

@mxstbr you are way too nice. It's basically the same lol

@Chiamaka Chiamaka deleted the markdown-hyperlinks branch January 17, 2019 09:13
@mxstbr
Copy link
Contributor

mxstbr commented Jan 17, 2019

I was lazy and did not add proper types in my PR, you did! 😊 Thanks for the contribution

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mxstbr mxstbr mxstbr approved these changes

Assignees
No one assigned
Labels
Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Chiamaka @brianlovin @mxstbr