This repository has been archived by the owner on Oct 11, 2022. It is now read-only.
[HOTFIX] Remove draftjs block type validation in messages #4543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is confusing now that we have the plaintext input, and doesn't add anything as invalid blocks are treated as text blocks anyway on the frontend.
Generated by 🚫 dangerJS |
brianlovin
reviewed
Jan 17, 2019
api/utils/validate-draft-js-input.js
Outdated
| }); | ||
|
|
||
| throw new UserError( | ||
| 'Please provide serialized raw DraftJS content state as content.body' |
There was a problem hiding this comment.
Should we have a slightly different error message that's a bit more user-friendly, like "The chat input only accepts inline markdown and code blocks. It looks like you tried to post something else!"
There was a problem hiding this comment.
Invalid block types (e.g. headings) will just be converted to text. Users will never see this after this PR, only folks who try to send invalid DraftJS content on purpose, so this is fine.
|
@mxstbr looks like this just needs a small flow fix and then we can merge :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Deploy after merge (delete what needn't be deployed)
This is confusing now that we have the plaintext input, and doesn't add anything as invalid blocks are treated as text blocks anyway on the frontend.
Going to hotfix ship this as it's breaking some users