-
-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: refactor sidebar label translations examples to use tags with regional subtags #881
docs: refactor sidebar label translations examples to use tags with regional subtags #881
Conversation
|
👷 Deploy Preview for astro-starlight processing.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great — thank you @HiDeoo!
Let’s hold off before merging this — I’d love to get a few outstanding translation PRs in before.
Co-authored-by: Chris Swithinbank <[email protected]> Co-authored-by: Kevin Zuniga Cuellar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely! Merge whenever you like @HiDeoo 🌟
* main: (42 commits) docs: refactor sidebar label translations examples to use tags with regional subtags (withastro#881) Add Nostalgist.js docs to showcase (withastro#900) i18n(id): Fix environmental-impact.md translation (withastro#899) i18n(es): Update `customization.mdx`, `i18n.mdx` & `configuration.md` (withastro#897) i18n(ko): update `configuration.md` (withastro#896) i18n(ko): update `i18n.mdx` (withastro#895) i18n(ko): update `customization.mdx` (withastro#894) [ci] format i18n(id): translate guides/components.mdx and guides/project-structure.mdx (withastro#898) [ci] format [ci] release (withastro#865) Add Patreon social link (withastro#892) [ci] format Add Ukrainian language support (withastro#891) i18n(id): Translate more pages and improve existing translations (withastro#859) [ci] format feat: add Reddit social icon (withastro#854) [ci] format i18n(ru): added translations for components, css-and-tailwind, environmental-impact, project-structure pages (withastro#888) i18n(id): translate `guides/authoring-content.md` (withastro#863) ...
* docs: refactor social links configuration reference * docs: update supported link icons wording Co-authored-by: Chris Swithinbank <[email protected]> * chore: add changes from #881 * chore: fix eof newline --------- Co-authored-by: Chris Swithinbank <[email protected]>
What kind of changes does this PR include?
Description
This pull request is an attempt to improve the documentation regarding the translation of sidebar labels following this issue on Discord. The scenario is the following:
Altho, this configuration does not translate the sidebar link label due to the fact that the key of the
translations
object should use a BCP-47 tag as key, which would bept-BR
in this case while the user thought it should bept-br
and match their file system structure.To improve this, this PR proposes the following changes: