Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n(es): Update guides/customization.mdx and reference/configuration.md #800

Merged
merged 7 commits into from
Oct 4, 2023
Merged

i18n(es): Update guides/customization.mdx and reference/configuration.md #800

merged 7 commits into from
Oct 4, 2023

Conversation

CodeF1ow
Copy link
Contributor

@CodeF1ow CodeF1ow commented Oct 3, 2023

What kind of changes does this PR include?

  • Changes or translations of Starlight docs site content

Description

@vercel
Copy link

vercel bot commented Oct 3, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Oct 3, 2023 8:49pm

@changeset-bot
Copy link

changeset-bot bot commented Oct 3, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8e5a651

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Oct 3, 2023 •
edited
Loading

👷 Deploy Preview for astro-starlight processing.

Name Link
🔨 Latest commit 8e5a651
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/651c7e127c9b37000854740d

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels Oct 3, 2023
delucis
delucis requested changes Oct 3, 2023
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @K1ri86!

There were also two more changes to these files adding Telegram and RSS icons:

Would you be able to update this PR to include those as well?

@CodeF1ow
Copy link
Contributor Author

CodeF1ow commented Oct 3, 2023

Thank you for the PR @K1ri86!

There were also two more changes to these files adding Telegram and RSS icons:

Would you be able to update this PR to include those as well?

Done 🚀

kevinzunigacuellar
kevinzunigacuellar approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@kevinzunigacuellar kevinzunigacuellar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

dreyfus92
dreyfus92 requested changes Oct 3, 2023
View reviewed changes
Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job @K1ri86, I left you a minor suggestion 😁

Waxer59
Waxer59 approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@Waxer59 Waxer59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔

delucis
delucis approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @K1ri86 and everyone who reviewed. Great team work 🙌

@delucis delucis merged commit afd26b7 into withastro:main Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HiDeoo HiDeoo HiDeoo left review comments

@dreyfus92 dreyfus92 dreyfus92 requested changes

@delucis delucis delucis approved these changes

@kevinzunigacuellar kevinzunigacuellar kevinzunigacuellar approved these changes

@Waxer59 Waxer59 Waxer59 approved these changes

Assignees
No one assigned
Labels
📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@CodeF1ow @delucis @HiDeoo @kevinzunigacuellar @Waxer59 @dreyfus92