-
-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use semantic color name instead of absolute color name #2792
Conversation
🦋 Changeset detectedLatest commit: 88ded8a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for astro-starlight ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
I think that we need to write a changeset for that. @dhruvkb Do you know how to do that? You can click the link in the changeset comment and describe the changes like that for example:
---
"@astrojs/starlight": patch
---
Uses hairline color variable for sidebar border.
Cool, I'll look into the docs and write one asap. |
Nice, I think it is documented here: https://contribute.docs.astro.build/docs-for-code-changes/changesets/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dhruvkb! I’ll add a changeset so we can merge this.
(For future reference, you can do this by running pnpm changeset
in the repo, or using the handy “Add changeset” link in the comment left on the PR by the changeset bot. But no worries, I’m always happy to add one myself if needed.)
Description
--sl-color-hairline
) instead of an absolute color name (--sl-color-gray-6
).