Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use semantic color name instead of absolute color name #2792

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

dhruvkb
Copy link
Contributor

@dhruvkb dhruvkb commented Jan 12, 2025

Description

  • Closes Right sidebar border does not respect hairline color #2790
  • This PR updates the right sidebar to use the semantic color name (--sl-color-hairline) instead of an absolute color name (--sl-color-gray-6).
  • This means that when a theme customises the hairline colors, the right sidebar will be automatically use that.

Copy link

changeset-bot bot commented Jan 12, 2025

🦋 Changeset detected

Latest commit: 88ded8a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Jan 12, 2025
Copy link

netlify bot commented Jan 12, 2025

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 88ded8a
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/6784e48cb1a18900081bfd71
😎 Deploy Preview https://deploy-preview-2792--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@trueberryless trueberryless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

I think that we need to write a changeset for that. @dhruvkb Do you know how to do that? You can click the link in the changeset comment and describe the changes like that for example:

---
"@astrojs/starlight": patch
---

Uses hairline color variable for sidebar border.

@dhruvkb
Copy link
Contributor Author

dhruvkb commented Jan 13, 2025

Cool, I'll look into the docs and write one asap.

@trueberryless
Copy link
Contributor

Nice, I think it is documented here: https://contribute.docs.astro.build/docs-for-code-changes/changesets/

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dhruvkb! I’ll add a changeset so we can merge this.

(For future reference, you can do this by running pnpm changeset in the repo, or using the handy “Add changeset” link in the comment left on the PR by the changeset bot. But no worries, I’m always happy to add one myself if needed.)

@delucis delucis added the 🌟 patch Change that triggers a patch release label Jan 13, 2025
@delucis delucis merged commit 412effb into withastro:main Jan 13, 2025
15 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 core Changes to Starlight’s main package 🌟 patch Change that triggers a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Right sidebar border does not respect hairline color
3 participants