-
-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes code example colour contrast #2708
Conversation
Co-authored-by: Hippo <[email protected]>
🦋 Changeset detectedLatest commit: b322788 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for astro-starlight ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
size-limit report 📦
|
Just a heads up: The code block styles on this page seem to be broken for me on iOS Safari in the deploy preview, not sure why that is the case: https://deploy-preview-2708--astro-starlight.netlify.app/environmental-impact/#caching The live site looks good. I can't imagine this one-line change causing this, so there might be something else going on. (Edit: The preview now also works after doing a rebuild with a cleared cache. Apparently this was a content collections caching issue unrelated to this particular change or EC. I'd be happy to let Astro know about any config changes requiring cache invalidation if an API is made available.) |
Oh that’s very odd… and I can reproduce the exact same behaviour in the dev server too. It appears that the Expressive Code styles are not loaded at all on that page: ![]() |
Figured out this was a caching issue due to how the Astro 5 content collection implementation caches Markdown across builds. Rebuilding on Netlify with a clear cache fixed it. This does make this change a bit riskier than it appears. Users might need to |
Would have loved to release this as a patch, but I think it will be safer in our next minor. At that time we can bump the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I checked the contrast in various pages, including tricky areas like marked lines including comments that had issues in the live site, and now the contrast levels are accessible everywhere.
Description