Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n(de): add preact integration guide #8625

Merged
merged 9 commits into from
Jun 24, 2024

Conversation

DerTimonius
Copy link
Contributor

Description (required)

supersedes #8146

This PR adds the missing german translation for the preact integration guide. I also made small change to the english version as the tutorial on the preact website is no longer called Learn Preact in 10 minutes, just Learn Preact.

Added the missing part from the original docs

Copy link

vercel bot commented Jun 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Jun 24, 2024 6:23pm

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Jun 21, 2024
@astrobot-houston
Copy link
Contributor

astrobot-houston commented Jun 21, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
de guides/integrations-guide/preact.mdx Localization added, will be marked as complete. 🔄️
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Contributor

@Maxframe Maxframe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Abgesehen von diesen zwei kleinen Vorschlägen, LGTM 💯

@yanthomasdev
Copy link
Member

Hey @DerTimonius, thanks for opening this PR again, could you make a separate PR for the change to the English version of this page? What I want is this:

  1. Remove the change to the English file from this PR.
  2. Make a new PR with only the English change, separate from the translation.

@DerTimonius
Copy link
Contributor Author

@yanthomasdev done! #8644

Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Amazing work peeps! 🙌

@yanthomasdev yanthomasdev merged commit 86da5b3 into withastro:main Jun 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants