-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n(ja): Update integrations-guide.mdx #7014
Merged
yanthomasdev
merged 5 commits into
withastro:main
from
morinokami:i18n-ja-integrations-guide-1
Mar 7, 2024
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
cfa3186
c25d1472620d41a85631f22e38f5666cc5e85fa5
morinokami 5efc4b6
cce0f376242c642a904f3af01e47c7ae91323599
morinokami 682e294
065ca4f586d8ccebec949d92a162764a740c6d60
morinokami e8e772d
e369859d64eae804c2fd48c1545a937af5d58b60
morinokami 6ae88f3
Merge branch 'main' into i18n-ja-integrations-guide-1
yanthomasdev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
たとえば→例えば
ここは漢字に直した方が良いのではないかと思います。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SnowDingo なるほど、ありがとうございます!こういった漢字の「閉じ・開き」(「全く」と「まったく」、「是非」と「ぜひ」、「又は」と「または」、などなど。https://note.com/swwwitch/n/n105a095c0687 が詳しいです)に関して、これまでは特に日本語訳プロジェクトにおいては厳密なルールなしに個々人の裁量に任せてきた感があるのですが、ここを漢字にしたほうがいい理由などはありますかね?個人的には、特にそうすることで誤読の可能性もないため、読みやすさのためにこの語は平仮名で書くことを通常としていました。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
漢字に直すよりひらがなの方がここは確かに良さそうですね。
僕的には漢字にして書いた方が読みやすいと思ったものの、ひらがなで書いても特に読みやすさが悪化する事は無さそうなので、変更なしでOkだと思います。
ただこういう所は今後さらに出てくるかもしれないので、近いうちに日本語翻訳のルール決めをする必要があると思います。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SnowDingo そうですね、なかなかすべてのルールを決めたり守ったりするのは大変そうですが、こういうふうに迷わないように指針があると良さそうですね!フィードバックありがとうございます🙏(そして問題なさそうであれば Approve して LGTM を残しておいていただけると)