Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(i18n): add documentation for custom paths #5526

Merged
merged 18 commits into from
Dec 5, 2023
Merged

Conversation

ematipico
Copy link
Member

@ematipico ematipico commented Nov 29, 2023

Description (required)

This PR adds documentation for refined locales, a way to customise paths and codes.

I was a bit unsure where to put the new paragraph because these refined locales span different concepts. For this reason, I put it at the end.

RFC changes: withastro/roadmap@dc277b5

For Astro version: next release. See astro PR #9200.

Copy link

vercel bot commented Nov 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Dec 5, 2023 2:44pm

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these great docs, @ematipico ! Here are some initial thoughts from a first pass through them for your consideration!

Co-authored-by: Sarah Rainsberger <[email protected]>
@ematipico
Copy link
Member Author

@sarah11918 Config name updated here 97919a8

@sarah11918 sarah11918 added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) labels Dec 1, 2023
@sarah11918
Copy link
Member

@ematipico I did some editing here and moved the content into a few different places where appropriate.

Please take a look and see what you think, and make any suggestions for what you'd like to see different!

@sarah11918 sarah11918 added the Docs is happy if OP is happy! Please review your PR and make sure you accept our proposed changes! label Dec 3, 2023
Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything's LGTM!

@ematipico ematipico changed the title feat(i18n): add documentation for refined locales feat(i18n): add documentation for custom paths Dec 4, 2023
@ematipico
Copy link
Member Author

I just pushed a commit. There were a few bugs around code highlighting. They should be good now

@sarah11918 sarah11918 added Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! and removed Docs is happy if OP is happy! Please review your PR and make sure you accept our proposed changes! labels Dec 4, 2023
@sarah11918 sarah11918 changed the title feat(i18n): add documentation for custom paths feat(i18n): add documentation for custom paths - merge after 5538 Dec 4, 2023
@sarah11918 sarah11918 changed the title feat(i18n): add documentation for custom paths - merge after 5538 feat(i18n): add documentation for custom paths Dec 5, 2023
@sarah11918 sarah11918 merged commit f4a0a6e into main Dec 5, 2023
@sarah11918 sarah11918 deleted the feat/refined-locales branch December 5, 2023 14:56
ematipico added a commit that referenced this pull request Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.0 add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants