-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prefetch docs #5271
Add prefetch docs #5271
Conversation
phew
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I read through the proposal and implementation and this looks exciting! I'll make a quick fix to links now, before I do an editing pass! 🚀 EDIT: Oops! Didn't see those were going to be links related to the new config docs. No worries, just noting for the record that this PR should merge AFTER 3.5's updated config docs, and the links should match up and be fine! |
Thanks for waiting, @bluwy ! I knew that most of what I wanted to do here was just some formatting esp. re: the migration section at the end. Sorry that it was easier for me to just take a pass at editing the file directly. I'm happy with this, so please just check for accuracy, or anything you'd like to change, and this will be good to go! |
Thanks for the review Sarah! No worries with the direct commit, it's always fine by me 👍 Reviewed the new changes and it looks great! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work on these docs, @bluwy!
@@ -0,0 +1,185 @@ | |||
--- | |||
title: Prefetch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need an actual comment here to trigger bot status
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The file `nav.ts` has been updated to align with the English language documentation based on this commits withastro#4876 , withastro#5183 , withastro#5213 , withastro#5271 , withastro#5187 , withastro#4667 , withastro#5541 , withastro#5605 , withastro#5499 , withastro#6470 , withastro#6620
Description (required)
Add prefetch docs (new core feature). Note that this supersedes
@astrojs/prefetch
with a different API.Related issues & labels (optional)