Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prefetch docs #5271

Merged
merged 4 commits into from
Nov 9, 2023
Merged

Add prefetch docs #5271

merged 4 commits into from
Nov 9, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Nov 3, 2023

Description (required)

Add prefetch docs (new core feature). Note that this supersedes @astrojs/prefetch with a different API.

Related issues & labels (optional)

  • Closes n/a
  • Suggested label: n/a

@bluwy bluwy added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) labels Nov 3, 2023
Copy link

netlify bot commented Nov 3, 2023

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 4b99eb2
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/654d24ed2e11e8000795287a
😎 Deploy Preview https://deploy-preview-5271--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sarah11918
Copy link
Member

sarah11918 commented Nov 3, 2023

I read through the proposal and implementation and this looks exciting! I'll make a quick fix to links now, before I do an editing pass! 🚀

EDIT: Oops! Didn't see those were going to be links related to the new config docs. No worries, just noting for the record that this PR should merge AFTER 3.5's updated config docs, and the links should match up and be fine!

@sarah11918 sarah11918 added the minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah! label Nov 5, 2023
@sarah11918
Copy link
Member

Thanks for waiting, @bluwy ! I knew that most of what I wanted to do here was just some formatting esp. re: the migration section at the end. Sorry that it was easier for me to just take a pass at editing the file directly.

I'm happy with this, so please just check for accuracy, or anything you'd like to change, and this will be good to go!

@bluwy
Copy link
Member Author

bluwy commented Nov 8, 2023

Thanks for the review Sarah! No worries with the direct commit, it's always fine by me 👍 Reviewed the new changes and it looks great!

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work on these docs, @bluwy!

@@ -0,0 +1,185 @@
---
title: Prefetch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need an actual comment here to trigger bot status

Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sarah11918 sarah11918 merged commit 30f6033 into main Nov 9, 2023
@sarah11918 sarah11918 deleted the prefetch-docs branch November 9, 2023 18:38
NinuzIBZ added a commit to NinuzIBZ/docs that referenced this pull request Feb 1, 2024
The file `nav.ts` has been updated to align with the English language documentation based on this commits withastro#4876 , withastro#5183 , withastro#5213 , withastro#5271 , withastro#5187 , withastro#4667 , withastro#5541 , withastro#5605 , withastro#5499 , withastro#6470 , withastro#6620
@NinuzIBZ NinuzIBZ mentioned this pull request Feb 1, 2024
yanthomasdev added a commit that referenced this pull request Feb 5, 2024
The file `nav.ts` has been updated to align with the English language documentation based on this commits #4876 , #5183 , #5213 , #5271 , #5187 , #4667 , #5541 , #5605 , #5499 , #6470 , #6620

Co-authored-by: Yan Thomas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants