Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSS Recipe Next Steps #3285

Merged
merged 18 commits into from
May 24, 2023
Merged

RSS Recipe Next Steps #3285

merged 18 commits into from
May 24, 2023

Conversation

Jothsa
Copy link
Contributor

@Jothsa Jothsa commented May 18, 2023

What kind of changes does this PR include?

  • New or updated content

Description

Thanks to @sarah11918 for the text I used.

I believe the address to visit to check your rss feed is my-site.com/rss.xml. I'm not 100% sure of the best/least awkward way to phrase that.

@netlify
Copy link

netlify bot commented May 18, 2023 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ae598b9
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/646df735a245200008918636
😎 Deploy Preview https://deploy-preview-3285--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Jothsa
Copy link
Contributor Author

Jothsa commented May 19, 2023

I'll edit this a bit now that I've read WRITING.md and RECIPES.md 😅

@sarah11918
Copy link
Member

This is my favourite PR comment EVER, @Jothsa 🤣

sarah11918
sarah11918 reviewed May 22, 2023
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Jothsa, there are some great improvements here! I've left some suggestions since this is a good excuse for me to review this page more generally, too!

@sarah11918 sarah11918 added the improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) label May 22, 2023
@Jothsa
Copy link
Contributor Author

Jothsa commented May 22, 2023

Thanks so much, @sarah11918!

@Jothsa
Copy link
Contributor Author

Jothsa commented May 22, 2023 •
edited
Loading

Not sure why the checks keep failing. Looks like fontsource is down.

If a sentence ends with a link, should the punctuation be included in the link or not? I try to include it

@sarah11918
Copy link
Member

Yup, we haven't been merging all afternoon because fontsource is down! Chris is working on a hotfix, and worst case, we wait until tomorrow.

If the sentence ends with link, the period is NOT included with the link! Punctuation is always separate from the text. :)

yanthomasdev
yanthomasdev reviewed May 23, 2023
View reviewed changes
Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a small typo, overall LGTM!

@sarah11918 sarah11918 merged commit 4af6dfc into withastro:main May 24, 2023
@morinokami morinokami mentioned this pull request Sep 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah11918 sarah11918 sarah11918 left review comments

@yanthomasdev yanthomasdev yanthomasdev left review comments

Assignees
No one assigned
Labels
improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RSS recipe missing final implementation step
3 participants
@Jothsa @sarah11918 @yanthomasdev